From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmR8n-0007b1-3e for qemu-devel@nongnu.org; Tue, 11 Jun 2013 12:09:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmR8k-0001rd-TN for qemu-devel@nongnu.org; Tue, 11 Jun 2013 12:09:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56231 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmR2j-0008AS-9d for qemu-devel@nongnu.org; Tue, 11 Jun 2013 12:03:33 -0400 Message-ID: <51B74A4E.2070106@suse.de> Date: Tue, 11 Jun 2013 18:03:26 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1370794247-28267-1-git-send-email-afaerber@suse.de> <1370794247-28267-10-git-send-email-afaerber@suse.de> <20130611105624.286109b2@redhat.com> In-Reply-To: <20130611105624.286109b2@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qiaonuohan@cn.fujitsu.com, qemu-devel@nongnu.org, Jens Freimann Am 11.06.2013 16:56, schrieb Luiz Capitulino: > On Sun, 9 Jun 2013 18:10:38 +0200 > Andreas F=C3=A4rber wrote: >=20 >> Change error reporting from return value to Error argument. >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> include/qom/cpu.h | 14 ++++++++++++++ >> include/sysemu/memory_mapping.h | 2 -- >> memory_mapping-stub.c | 6 ------ >> memory_mapping.c | 7 ++++--- >> qom/cpu.c | 16 ++++++++++++++++ >> target-i386/arch_memory_mapping.c | 12 +++++++----- >> target-i386/cpu-qom.h | 3 +++ >> target-i386/cpu.c | 1 + >> 8 files changed, 45 insertions(+), 16 deletions(-) >> >> diff --git a/include/qom/cpu.h b/include/qom/cpu.h >> index 1f70240..254be2e 100644 >> --- a/include/qom/cpu.h >> +++ b/include/qom/cpu.h [...] >> @@ -148,6 +152,16 @@ struct CPUState { >> bool cpu_paging_enabled(const CPUState *cpu); >> =20 >> /** >> + * @cpu: The CPU whose memory mappings are to be obtained. >> + * @list: Where to write the memory mappings to. >> + * @errp: Pointer for reporting an #Error. >> + * >> + * Returns: 0 if successful. >> + */ >=20 > It turns void now, but you can add: >=20 > Reviewed-by: Luiz Capitulino >=20 > When you respin. Thanks, fixing up as follows: diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 254be2e..a5bb515 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -152,11 +152,10 @@ struct CPUState { bool cpu_paging_enabled(const CPUState *cpu); /** + * cpu_get_memory_mapping: * @cpu: The CPU whose memory mappings are to be obtained. * @list: Where to write the memory mappings to. * @errp: Pointer for reporting an #Error. - * - * Returns: 0 if successful. */ void cpu_get_memory_mapping(CPUState *cpu, MemoryMappingList *list, Error **errp); Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg