From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists Date: Tue, 11 Jun 2013 09:04:10 -0700 Message-ID: <51B74A7A.1040707@sr71.net> References: <1370964919-16187-1-git-send-email-kirill.shutemov@linux.intel.com> <1370964919-16187-3-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Kirill A. Shutemov" Return-path: In-Reply-To: <1370964919-16187-3-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 06/11/2013 08:35 AM, Kirill A. Shutemov wrote: > active/inactive lru lists can contain unevicable pages (i.e. ramfs pages > that have been placed on the LRU lists when first allocated), but these > pages must not have PageUnevictable set - otherwise shrink_[in]active_list > goes crazy: I think it's also important here to note if this is a bug that can be hit _currently_, or if this really is just a preparatory patch for transparent huge page cache. >>From what I can see, this is _needed_ preparatory work, but it can also stand on its own because it simplifies things. It should go in sooner rather than later. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755131Ab3FKQEN (ORCPT ); Tue, 11 Jun 2013 12:04:13 -0400 Received: from www.sr71.net ([198.145.64.142]:43589 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753424Ab3FKQEL (ORCPT ); Tue, 11 Jun 2013 12:04:11 -0400 Message-ID: <51B74A7A.1040707@sr71.net> Date: Tue, 11 Jun 2013 09:04:10 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists References: <1370964919-16187-1-git-send-email-kirill.shutemov@linux.intel.com> <1370964919-16187-3-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1370964919-16187-3-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2013 08:35 AM, Kirill A. Shutemov wrote: > active/inactive lru lists can contain unevicable pages (i.e. ramfs pages > that have been placed on the LRU lists when first allocated), but these > pages must not have PageUnevictable set - otherwise shrink_[in]active_list > goes crazy: I think it's also important here to note if this is a bug that can be hit _currently_, or if this really is just a preparatory patch for transparent huge page cache. >>From what I can see, this is _needed_ preparatory work, but it can also stand on its own because it simplifies things. It should go in sooner rather than later.