All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/4] staging:iio:adis16130: Move out of staging
Date: Tue, 11 Jun 2013 20:35:31 +0100	[thread overview]
Message-ID: <51B77C03.1030500@kernel.org> (raw)
In-Reply-To: <1370872815-14386-4-git-send-email-lars@metafoo.de>

On 06/10/2013 03:00 PM, Lars-Peter Clausen wrote:
> The adis16130 driver is fairly simple and it a good shape now, so move it out of
> staging. Remove an outdated FIXME along the way.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git

Thanks for tidying this one up and getting out of staging.  Lots more to go ;)
> ---
>  drivers/iio/gyro/Kconfig                                           | 7 +++++++
>  drivers/iio/gyro/Makefile                                          | 1 +
>  .../{staging/iio/gyro/adis16130_core.c => iio/gyro/adis16130.c}    | 1 -
>  drivers/staging/iio/gyro/Kconfig                                   | 7 -------
>  drivers/staging/iio/gyro/Makefile                                  | 3 ---
>  5 files changed, 8 insertions(+), 11 deletions(-)
>  rename drivers/{staging/iio/gyro/adis16130_core.c => iio/gyro/adis16130.c} (99%)
> 
> diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
> index b8daf1b..8498e9d 100644
> --- a/drivers/iio/gyro/Kconfig
> +++ b/drivers/iio/gyro/Kconfig
> @@ -10,6 +10,13 @@ config ADIS16080
>  	  Say yes here to build support for Analog Devices ADIS16080, ADIS16100 Yaw
>  	  Rate Gyroscope with SPI.
>  
> +config ADIS16130
> +	tristate "Analog Devices ADIS16130 High Precision Angular Rate Sensor driver"
> +	depends on SPI
> +	help
> +	  Say yes here to build support for Analog Devices ADIS16130 High Precision
> +	  Angular Rate Sensor driver.
> +
>  config ADIS16136
>  	tristate "Analog devices ADIS16136 and similar gyroscopes driver"
>  	depends on SPI_MASTER
> diff --git a/drivers/iio/gyro/Makefile b/drivers/iio/gyro/Makefile
> index 225d289..e9dc034 100644
> --- a/drivers/iio/gyro/Makefile
> +++ b/drivers/iio/gyro/Makefile
> @@ -3,6 +3,7 @@
>  #
>  
>  obj-$(CONFIG_ADIS16080) += adis16080.o
> +obj-$(CONFIG_ADIS16130) += adis16130.o
>  obj-$(CONFIG_ADIS16136) += adis16136.o
>  obj-$(CONFIG_ADXRS450) += adxrs450.o
>  
> diff --git a/drivers/staging/iio/gyro/adis16130_core.c b/drivers/iio/gyro/adis16130.c
> similarity index 99%
> rename from drivers/staging/iio/gyro/adis16130_core.c
> rename to drivers/iio/gyro/adis16130.c
> index 8979435..129acdf 100644
> --- a/drivers/staging/iio/gyro/adis16130_core.c
> +++ b/drivers/iio/gyro/adis16130.c
> @@ -183,7 +183,6 @@ error_ret:
>  	return ret;
>  }
>  
> -/* fixme, confirm ordering in this function */
>  static int adis16130_remove(struct spi_device *spi)
>  {
>  	iio_device_unregister(spi_get_drvdata(spi));
> diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
> index 8360662..b433371 100644
> --- a/drivers/staging/iio/gyro/Kconfig
> +++ b/drivers/staging/iio/gyro/Kconfig
> @@ -10,13 +10,6 @@ config ADIS16060
>  	  Say yes here to build support for Analog Devices adis16060 wide bandwidth
>  	  yaw rate gyroscope with SPI.
>  
> -config ADIS16130
> -	tristate "Analog Devices ADIS16130 High Precision Angular Rate Sensor driver"
> -	depends on SPI
> -	help
> -	  Say yes here to build support for Analog Devices ADIS16130 High Precision
> -	  Angular Rate Sensor driver.
> -
>  config ADIS16260
>  	tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
>  	depends on SPI
> diff --git a/drivers/staging/iio/gyro/Makefile b/drivers/staging/iio/gyro/Makefile
> index 98e6500..975f95b 100644
> --- a/drivers/staging/iio/gyro/Makefile
> +++ b/drivers/staging/iio/gyro/Makefile
> @@ -5,8 +5,5 @@
>  adis16060-y             := adis16060_core.o
>  obj-$(CONFIG_ADIS16060) += adis16060.o
>  
> -adis16130-y             := adis16130_core.o
> -obj-$(CONFIG_ADIS16130) += adis16130.o
> -
>  adis16260-y             := adis16260_core.o
>  obj-$(CONFIG_ADIS16260) += adis16260.o
> 

  reply	other threads:[~2013-06-11 19:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 14:00 [PATCH 1/4] staging:iio:adis16130: Remove unused includes Lars-Peter Clausen
2013-06-10 14:00 ` [PATCH 2/4] staging:iio:adis16130: Fix sample reading Lars-Peter Clausen
2013-06-11 19:33   ` Jonathan Cameron
2013-06-10 14:00 ` [PATCH 3/4] staging:iio:adis16130: Report scale and offset Lars-Peter Clausen
2013-06-11 19:34   ` Jonathan Cameron
2013-06-10 14:00 ` [PATCH 4/4] staging:iio:adis16130: Move out of staging Lars-Peter Clausen
2013-06-11 19:35   ` Jonathan Cameron [this message]
2013-06-11 19:32 ` [PATCH 1/4] staging:iio:adis16130: Remove unused includes Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B77C03.1030500@kernel.org \
    --to=jic23@kernel.org \
    --cc=jic23@cam.ac.uk \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.