From mboxrd@z Thu Jan 1 00:00:00 1970 From: wenchao Subject: Re: [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found Date: Wed, 12 Jun 2013 09:39:50 +0800 Message-ID: <51B7D166.3000109@gmail.com> References: <1369731284-4139-1-git-send-email-wenchaolinux@gmail.com> <20130528092539.GA22269@hj.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130528092539.GA22269@hj.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Asias He Cc: kvm@vger.kernel.org, mst@redhat.com, Greg Kroah-Hartman , virtualization@lists.linux-foundation.org, linux-next@vger.kernel.org, wenchaolinuxkvm@gmail.com, pbonzini@redhat.com List-Id: linux-next.vger.kernel.org cc to Greg for 3.9. > On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia wrote: >> ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget >> to set it correctly in configfs, make user confused. Actually it fail >> to find a matching one, so change the error value. >> >> Signed-off-by: Wenchao Xia > > Acked-by: Asias He > > BTW, It would be nice to print more informative info in qemu when wwpn > is not available as well. > >> --- >> drivers/vhost/scsi.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c >> index 7014202..6325b1d 100644 >> --- a/drivers/vhost/scsi.c >> +++ b/drivers/vhost/scsi.c >> @@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint( >> } >> ret = 0; >> } else { >> - ret = -EEXIST; >> + ret = -ENOENT; >> } >> >> /* >> -- >> 1.7.1 >> >