From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] fdt: remove unaligned access in fdt_fixup_ethernet()
Date: Tue, 11 Jun 2013 21:55:22 -0400 [thread overview]
Message-ID: <51B7D50A.3030307@gmail.com> (raw)
In-Reply-To: <20130607181909.GF26693@bill-the-cat>
Hi Stephen,
Sorry for not applying this in a timely manner. Thanks, Tom, for
covering for me.
gvb
On 06/07/2013 02:19 PM, Tom Rini wrote:
> On Mon, May 27, 2013 at 06:01:19PM -0000, Stephen Warren wrote:
>
>> Some ARM compilers may emit code that makes unaligned accesses when
>> faced with constructs such as:
>>
>> char mac[16] = "ethaddr";
>>
>> Replace this with a strcpy() call instead to avoid this. strcpy() is
>> used here, rather than replacing all usage of the mac variable with the
>> string itself, since the loop itself sprintf()s to the variable each
>> iteration, so strcpy() is doing basically the same thing.
>>
>> Reported-by: Florian Meier
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>
> Applied to u-boot/master, thanks!
prev parent reply other threads:[~2013-06-12 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 4:01 [U-Boot] [PATCH] fdt: remove unaligned access in fdt_fixup_ethernet() Stephen Warren
2013-05-28 4:05 ` Michael Trimarchi
2013-05-28 4:16 ` Stephen Warren
2013-06-05 3:41 ` Stephen Warren
2013-06-07 18:19 ` [U-Boot] " Tom Rini
2013-06-12 1:55 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B7D50A.3030307@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.