Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

[Gerd Hoffmann <kraxel@redhat.com>]

On 06/11/13 08:12, Gerd Hoffmann wrote:
>   Hi,
> 
>>> +static QEMUCursor                 *ptr_cursor;
>>> +static pixman_image_t             *ptr_image;
>>> +static int                        ptr_refresh;
>>> +static int                        px, py, pw, ph;
>>> +static int                        mx, my, mon;
>>> +
>>> +/* options */
>>> +static int                        use_scale;
>>> +static pixman_filter_t            pfilter = PIXMAN_FILTER_GOOD;
>>
>> Should stick all of this within a structure and pass it around where
>> possible.
> 
> Don't see what this buys us as there can be only a single framebuffer
> display anyway.  Can do that though.

While looking into it:  I can't get rid of global variables _anyway_.
fbdev needs signal handlers to work.  Absolutely required for console
switching.  Nice to have for catching fatal signals and restoring
console state.

Still want me move this into a struct?

cheers,
  Gerd