From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
David Woodhouse <David.Woodhouse@intel.com>,
Matt Fleming <matt.fleming@intel.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] x86, relocs: move ELF relocation handling to C
Date: Wed, 12 Jun 2013 11:14:42 -0700 [thread overview]
Message-ID: <51B8BA92.2090801@zytor.com> (raw)
In-Reply-To: <CAE9FiQXgO+yScU2cBazJtX2mFHRMv=wObrTjpFvW5ajFNjBvCA@mail.gmail.com>
On 06/12/2013 11:13 AM, Yinghai Lu wrote:
>
> it seems those lines for x86_64 are never used.
> as X86_NEED_RELOCS is not defined for x86_64
>
>> config X86_NEED_RELOCS
>> def_bool y
>> depends on X86_32 && RELOCATABLE
>
>
>> +}
>> +#else
>> +static inline void handle_relocations(void *output, unsigned long output_len)
>> +{ }
>> +#endif
>
> Can you make it clear that this patch only affect x86_32 in patch title?
>
I am not sure this belongs in the patch title, as it is preparatory work
for x86-64. It should be mentioned in the patch description body, though.
-hpa
prev parent reply other threads:[~2013-06-12 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 18:58 [PATCH] x86, relocs: move ELF relocation handling to C Kees Cook
2013-06-12 6:27 ` Pekka Enberg
2013-06-12 16:26 ` Kees Cook
2013-06-12 17:01 ` Pekka Enberg
2013-06-12 18:13 ` Yinghai Lu
2013-06-12 18:14 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B8BA92.2090801@zytor.com \
--to=hpa@zytor.com \
--cc=David.Woodhouse@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.