From: Jagan Teki <jagannadh.teki@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] FSL SPI read fix.
Date: Thu, 13 Jun 2013 00:32:39 +0530 [thread overview]
Message-ID: <51B8C5CF.9070307@gmail.com> (raw)
In-Reply-To: <CAFGZJC5LGE-ynbcKKc1kB=g1PQxkyzTUStngGQsHBmUSaPcJuw@mail.gmail.com>
Hi,
Can you please update the commit header and logic of the code
w.r.t current master tree.
also please use proper commit body.
--
Thanks,
Jagan.
On 27-09-2012 02:37, Dale Smith wrote:
> The fsl spi engine is non functional when reading from a device. This
> patch fixes it.
>
> Note that none of the other spi interfaces parse through the
> datastream looking for 0x0b bytes.
>
> -Dale
>
> }
>
>
> diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c
> index a1ebd33..737719b 100644
> --- a/drivers/spi/fsl_espi.c
> +++ b/drivers/spi/fsl_espi.c
> @@ -291,17 +291,10 @@ int spi_xfer(struct spi_slave *slave, unsigned
> int bitlen, const void *data_out,
> debug("***spi_xfer:...%08x readed\n", tmpdin);
> }
> }
> - if (data_in) {
> - memcpy(data_in, buffer + 2 * cmd_len, tran_len);
> - if (*buffer == 0x0b) {
> - data_in += tran_len;
> - data_len -= tran_len;
> - *(int *)buffer += tran_len;
> - }
> - }
> spi_cs_deactivate(slave);
> }
> -
> + if (data_in)
> + memcpy(data_in, buffer + rx_offset, len);
> free(buffer);
> return 0;
>
next prev parent reply other threads:[~2013-06-12 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 21:07 [U-Boot] [PATCH] FSL SPI read fix Dale Smith
2013-06-12 19:02 ` Jagan Teki [this message]
2013-06-12 21:54 ` [U-Boot] [PATCH] FSL espi: Return all data read from device unmodified Dale P. Smith
2013-06-13 2:39 ` Jagan Teki
2013-06-13 9:09 ` Albert ARIBAUD
2013-06-13 9:22 ` Jagan Teki
2015-12-12 2:19 ` [U-Boot] [PATCH v3] spi: fsl_espi: " Dale P. Smith
2015-12-12 17:10 ` Joakim Tjernlund
2015-12-14 7:01 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B8C5CF.9070307@gmail.com \
--to=jagannadh.teki@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.