From: Jagan Teki <jagannadh.teki@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] exynos5250: remove redundant SPI and PMIC related configs
Date: Thu, 13 Jun 2013 01:08:50 +0530 [thread overview]
Message-ID: <51B8CE4A.9010604@gmail.com> (raw)
In-Reply-To: <1370606139-2529-1-git-send-email-inderpal.singh@linaro.org>
Hi,
Can you separate the PMIC and SPI changes into two different patches.
Also may i know why you remove the SPI from configs, does it defined
some where or you don't want SPI at all.?
--
Thanks,
Jagan.
On 07-06-2013 17:25, Inderpal Singh wrote:
> They have been defined once already. Hence remove the redundant definitions.
>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
> v1 was posted as the first patch of [1]
>
> Changes in v2:
> - split from the patchset at [1]
> - removed redundant configs for PMIC
> - rebased to latest u-boot-samsung master branch
>
> [1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101
>
> include/configs/exynos5250-dt.h | 26 --------------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
> index 62b83d4..03b07b2 100644
> --- a/include/configs/exynos5250-dt.h
> +++ b/include/configs/exynos5250-dt.h
> @@ -246,11 +246,6 @@
> #define CONFIG_SYS_I2C_SLAVE 0x0
> #define CONFIG_I2C_EDID
>
> -/* PMIC */
> -#define CONFIG_PMIC
> -#define CONFIG_PMIC_I2C
> -#define CONFIG_PMIC_MAX77686
> -
> /* SPI */
> #define CONFIG_ENV_IS_IN_SPI_FLASH
> #define CONFIG_SPI_FLASH
> @@ -278,27 +273,6 @@
> #define CONFIG_POWER_I2C
> #define CONFIG_POWER_MAX77686
>
> -/* SPI */
> -#define CONFIG_ENV_IS_IN_SPI_FLASH
> -#define CONFIG_SPI_FLASH
> -
> -#ifdef CONFIG_SPI_FLASH
> -#define CONFIG_EXYNOS_SPI
> -#define CONFIG_CMD_SF
> -#define CONFIG_CMD_SPI
> -#define CONFIG_SPI_FLASH_WINBOND
> -#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
> -#define CONFIG_SF_DEFAULT_SPEED 50000000
> -#define EXYNOS5_SPI_NUM_CONTROLLERS 5
> -#endif
> -
> -#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
> -#define CONFIG_ENV_SPI_MODE SPI_MODE_0
> -#define CONFIG_ENV_SECT_SIZE CONFIG_ENV_SIZE
> -#define CONFIG_ENV_SPI_BUS 1
> -#define CONFIG_ENV_SPI_MAX_HZ 50000000
> -#endif
> -
> /* Ethernet Controllor Driver */
> #ifdef CONFIG_CMD_NET
> #define CONFIG_SMC911X
>
next prev parent reply other threads:[~2013-06-12 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 11:55 [U-Boot] [PATCH v2] exynos5250: remove redundant SPI and PMIC related configs Inderpal Singh
2013-06-12 19:38 ` Jagan Teki [this message]
2013-06-20 8:10 ` Inderpal Singh
2013-08-08 13:45 ` Jagan Teki
2013-12-20 19:00 ` Jagan Teki
2014-01-07 2:13 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B8CE4A.9010604@gmail.com \
--to=jagannadh.teki@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.