From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51B8F729.7030907@metafoo.de> Date: Thu, 13 Jun 2013 00:33:13 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 Subject: Re: [PATCH] pwm: Fill in missing .owner fields References: <1371036553-32263-1-git-send-email-thierry.reding@gmail.com> <20130612195917.GA31835@mithrandir> In-Reply-To: <20130612195917.GA31835@mithrandir> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-ID: To: Thierry Reding Cc: Sachin Kamat , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman On 06/12/2013 09:59 PM, Thierry Reding wrote: > On Wed, Jun 12, 2013 at 05:05:18PM +0530, Sachin Kamat wrote: >> Hi Thierry, >> >> On 12 June 2013 16:59, Thierry Reding wrote: >>> Some drivers don't set the .owner fields of the struct device_driver or >>> struct pwm_ops, which causes the module usage count to become wrong. >> >> >> Recently a patch [1] was added to solve this issue of missing .owner >> fileds in struct platform_driver. > > Yes I saw that, but thought it might be good to initialize them anyway. > Especially since a couple of the drivers are I2C and I believe there's > no similar patch for those. It shouldn't be difficult to come up with > the corresponding patch, though. I2C had the same actually for quite some time now.