Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

[Brad Smith <brad@comstyle.com>]

On 11/06/13 8:57 AM, Michael Tokarev wrote:
> 05.06.2013 19:25, Michael Tokarev wrote:
>> In two places qemu uses openpty() which is very system-dependent,
>> and in both places the pty is switched to raw mode as well.
>> Make a wrapper function which does both steps, and move all the
>> system-dependent complexity into a separate file, together
>> with static/local implementations of openpty() and cfmakeraw()
>> from qemu-char.c.
>>
>> It is in a separate file, not part of oslib-posix.c, because
>> openpty() often resides in -lutil which is not linked to
>> every program qemu builds.
>>
>> This change removes #including of <pty.h>, <termios.h>
>> and other rather specific system headers out of qemu-common.h,
>> which isn't a place for such specific headers really.
>
> So guys/gals what do you think of this?  It builds on OpenBSD
> and FreeBSD as verified by Brad Smith and me, and it builds on
> Linux.  And it is trivial enough for qemu-trivial (no actual
> code changes, just some refactoring and moving).  Can we
> let it in?
>
> There's no one else who signed this off ;)
>
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

It would be nice to get this in to fix the build with Solaris (that's
if there is nothing else I am not aware of which breaks the build there) 
and to get this in the queue for 1.5 too.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.