From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <51B93FA2.7040206@atmel.com> Date: Thu, 13 Jun 2013 11:42:26 +0800 From: Josh Wu MIME-Version: 1.0 To: Sergei Shtylyov Subject: Re: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes References: <1370860014-1770-1-git-send-email-josh.wu@atmel.com> <1370860014-1770-7-git-send-email-josh.wu@atmel.com> <51B5C80D.2030303@cogentembedded.com> In-Reply-To: <51B5C80D.2030303@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, Sergei On 6/10/2013 8:35 PM, Sergei Shtylyov wrote: > hello. > > On 10-06-2013 14:26, Josh Wu wrote: > >> If the child node has compatible property then it is a driver not >> partition. > >> Signed-off-by: Josh Wu >> --- >> drivers/mtd/ofpart.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > >> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c >> index 553d6d6..61ce1f8 100644 >> --- a/drivers/mtd/ofpart.c >> +++ b/drivers/mtd/ofpart.c > [...] >> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info >> *master, >> /* First count the subnodes */ >> pp = NULL; >> nr_parts = 0; >> - while ((pp = of_get_next_child(node, pp))) >> + while ((pp = of_get_next_child(node, pp))) { > > Assignment in *while*? Is scripts/checkpatch.pl happy about that? yes, checkpatch.pl has no complain ;-) > >> + int len; > > Empty line wouldn't hurt here, after declaration. Ok, as Brian said, I will no need to use a 'int len' here. So I will remove those declaration. > >> + if (node_has_compatible(pp, &len)) >> + continue; >> + >> nr_parts++; >> + } >> >> if (nr_parts == 0) >> return 0; > > WBR, Sergei > Thanks. Best Regards, Josh Wu From mboxrd@z Thu Jan 1 00:00:00 1970 From: josh.wu@atmel.com (Josh Wu) Date: Thu, 13 Jun 2013 11:42:26 +0800 Subject: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes In-Reply-To: <51B5C80D.2030303@cogentembedded.com> References: <1370860014-1770-1-git-send-email-josh.wu@atmel.com> <1370860014-1770-7-git-send-email-josh.wu@atmel.com> <51B5C80D.2030303@cogentembedded.com> Message-ID: <51B93FA2.7040206@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Sergei On 6/10/2013 8:35 PM, Sergei Shtylyov wrote: > hello. > > On 10-06-2013 14:26, Josh Wu wrote: > >> If the child node has compatible property then it is a driver not >> partition. > >> Signed-off-by: Josh Wu >> --- >> drivers/mtd/ofpart.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > >> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c >> index 553d6d6..61ce1f8 100644 >> --- a/drivers/mtd/ofpart.c >> +++ b/drivers/mtd/ofpart.c > [...] >> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info >> *master, >> /* First count the subnodes */ >> pp = NULL; >> nr_parts = 0; >> - while ((pp = of_get_next_child(node, pp))) >> + while ((pp = of_get_next_child(node, pp))) { > > Assignment in *while*? Is scripts/checkpatch.pl happy about that? yes, checkpatch.pl has no complain ;-) > >> + int len; > > Empty line wouldn't hurt here, after declaration. Ok, as Brian said, I will no need to use a 'int len' here. So I will remove those declaration. > >> + if (node_has_compatible(pp, &len)) >> + continue; >> + >> nr_parts++; >> + } >> >> if (nr_parts == 0) >> return 0; > > WBR, Sergei > Thanks. Best Regards, Josh Wu