From: "Andreas Färber" <afaerber@suse.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: stefano.stabellini@eu.citrix.com, mtosatti@redhat.com,
agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory
Date: Thu, 13 Jun 2013 10:33:09 +0200 [thread overview]
Message-ID: <51B983C5.3060107@suse.de> (raw)
In-Reply-To: <1371106939-6968-8-git-send-email-armbru@redhat.com>
Am 13.06.2013 09:02, schrieb Markus Armbruster:
> We abort() on memory allocation failure. abort() is appropriate for
> programming errors. Maybe most memory allocation failures are
> programming errors, maybe not. But guest memory allocation failure
> isn't, and aborting when the user asks for more memory than we can
> provide is not nice. exit(1) instead, and do it in just one place, so
> the error message is consistent.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Andreas Färber <afaerber@suse.de>
Thanks for looking into this!
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-13 8:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 7:02 [Qemu-devel] [PATCH RFC 0/8] Guest memory allocation fixes & cleanup Markus Armbruster
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 1/8] exec: Fix Xen RAM allocation with unusual options Markus Armbruster
2013-06-13 11:54 ` Stefano Stabellini
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 2/8] exec: Clean up fall back when -mem-path allocation fails Markus Armbruster
2013-06-13 22:12 ` Paolo Bonzini
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 3/8] exec: Reduce ifdeffery around -mem-path Markus Armbruster
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 4/8] s390: Simplify the RAM allocation hook Markus Armbruster
2013-06-13 8:19 ` Andreas Färber
2013-06-13 22:14 ` Paolo Bonzini
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 5/8] s390: Make qemu_ram_remap() consistent with allocation Markus Armbruster
2013-06-13 22:19 ` Paolo Bonzini
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery Markus Armbruster
2013-06-13 22:21 ` Paolo Bonzini
2013-06-14 8:06 ` Markus Armbruster
2013-06-15 17:26 ` Paolo Bonzini
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory Markus Armbruster
2013-06-13 8:33 ` Andreas Färber [this message]
2013-06-13 16:02 ` Richard Henderson
2013-06-13 17:27 ` Markus Armbruster
2013-06-13 16:21 ` Peter Maydell
2013-06-13 17:27 ` Markus Armbruster
2013-06-13 7:02 ` [Qemu-devel] [PATCH RFC 8/8] pc_sysfw: Fix ISA BIOS init for ridiculously big flash Markus Armbruster
2013-06-13 7:05 ` [Qemu-devel] [PATCH RFC 0/8] Guest memory allocation fixes & cleanup Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B983C5.3060107@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.