From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un2y3-0008WN-Pj for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Un2y0-0000j7-Co for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:33:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44956 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un2y0-0000iR-6q for qemu-devel@nongnu.org; Thu, 13 Jun 2013 04:33:12 -0400 Message-ID: <51B983C5.3060107@suse.de> Date: Thu, 13 Jun 2013 10:33:09 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1371106939-6968-1-git-send-email-armbru@redhat.com> <1371106939-6968-8-git-send-email-armbru@redhat.com> In-Reply-To: <1371106939-6968-8-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: stefano.stabellini@eu.citrix.com, mtosatti@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, pbonzini@redhat.com Am 13.06.2013 09:02, schrieb Markus Armbruster: > We abort() on memory allocation failure. abort() is appropriate for > programming errors. Maybe most memory allocation failures are > programming errors, maybe not. But guest memory allocation failure > isn't, and aborting when the user asks for more memory than we can > provide is not nice. exit(1) instead, and do it in just one place, so > the error message is consistent. >=20 > Signed-off-by: Markus Armbruster Acked-by: Andreas F=E4rber Thanks for looking into this! Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg