From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] freetype: fix includedir
Date: Thu, 13 Jun 2013 07:28:09 -0300 [thread overview]
Message-ID: <51B99EB9.8010401@zacarias.com.ar> (raw)
In-Reply-To: <51B961CA.6080405@mind.be>
On 06/13/2013 03:08 AM, Arnout Vandecappelle wrote:
> I think this is the wrong fix.
>
> The FREETYPE_CONFIG_SCRIPTS approach doesn't work in this case because
> this script doesn't use ${prefix} in front of it's includedir. I think
> the better fix is to use a custom POST_INSTALL_STAGING_HOOK that sets
> SYSROOT=$(STAGING_DIR) at the beginning of the script.
>
> The .pc file should be handled by our modified pkg-config.
>
> Regards,
> Arnout
I've actually mentioned the pkgconfig file because of late fixing /
killing time, so as you said it really doesn't matter, it's handled
elsewhere.
Setting SYSROOT at the beginning of the script is wrong too IMHO, it's
very unconventional, we should just revert it back to the tried and
tested way that every other -config script works fine with:
includedir="${prefix}/include"
libdir="${exec_prefix}/lib"
I'll spin a V2.
Regards.
next prev parent reply other threads:[~2013-06-13 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 3:28 [Buildroot] [PATCH] freetype: fix includedir Gustavo Zacarias
2013-06-13 6:08 ` Arnout Vandecappelle
2013-06-13 10:28 ` Gustavo Zacarias [this message]
2013-06-13 12:25 ` Sagaert Johan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B99EB9.8010401@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.