All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Alexander Graf <agraf@suse.de>,
	Programmingkid <programmingkidx@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X
Date: Thu, 13 Jun 2013 12:42:37 +0200	[thread overview]
Message-ID: <51B9A21D.3010901@web.de> (raw)
In-Reply-To: <1371046972-32056-1-git-send-email-kwolf@redhat.com>

Am 12.06.2013 16:22, schrieb Kevin Wolf:
> The raw-posix driver has code to provide a /dev/cdrom on OS X even
> though it doesn't really exist. However, since commit c66a6157 the real
> filename is dismissed after finding it, so opening /dev/cdrom fails.
> Put the filename back into the options QDict to make this work again.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/raw-posix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index c0ccf27..90ce9f8 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1350,6 +1350,7 @@ static int hdev_open(BlockDriverState *bs, QDict *options, int flags)
>                  qemu_close(fd);
>              }
>              filename = bsdPath;
> +            qdict_put(options, "filename", qstring_from_str(filename));
>          }
>  
>          if ( mediaIterator )

On Mac OS X v10.5.8 ppc64 I get:

qemu-system-x86_64: -cdrom /dev/cdrom: could not open disk image
/dev/cdrom: No such file or directory

On ppc I get a crash even without options, seems unrelated though.

Andreas

      parent reply	other threads:[~2013-06-13 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 14:22 [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X Kevin Wolf
2013-06-13  8:37 ` Stefan Hajnoczi
2013-06-13 10:42 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B9A21D.3010901@web.de \
    --to=andreas.faerber@web.de \
    --cc=agraf@suse.de \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.