From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Un7NE-0005Ad-Il
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 09:15:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Un7NC-0006cj-8u
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 09:15:32 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55487 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Un7NC-0006cN-2b
	for qemu-devel@nongnu.org; Thu, 13 Jun 2013 09:15:30 -0400
Message-ID: <51B9C5F1.2020503@suse.de>
Date: Thu, 13 Jun 2013 15:15:29 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370606786-5650-1-git-send-email-mans@mansr.com>
	<1370606786-5650-3-git-send-email-mans@mansr.com>
In-Reply-To: <1370606786-5650-3-git-send-email-mans@mansr.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL
	instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mans Rullgard <mans@mansr.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

Am 07.06.2013 14:06, schrieb Mans Rullgard:
> The ARMv8 SEVL instruction is in the architectural hint space already
> emulated as nop.  This makes the decoding of SEVL explicit for clarity.
>=20
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
>  target-arm/translate.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index f529257..cfd148e 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -3501,6 +3501,7 @@ static void gen_nop_hint(DisasContext *s, int val=
)
>          break;
>      case 2: /* wfe */
>      case 4: /* sev */
> +    case 5: /* sevl */
>          /* TODO: Implement SEV and WFE.  May help SMP performance.  */
>      default: /* nop */
>          break;

So does SEVL need to be implemented? Then the TODO should be updated.
Otherwise moving it a line down may be clearer.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg