All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagannadh.teki@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave
Date: Thu, 13 Jun 2013 19:38:42 +0530	[thread overview]
Message-ID: <51B9D26A.9090109@gmail.com> (raw)
In-Reply-To: <201306131248.39579.marex@denx.de>

On 13-06-2013 16:18, Marek Vasut wrote:
> Dear Axel Lin,
>
>> It's done in spi_alloc_slave(), thus remove the redundant code.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>>   drivers/spi/tegra20_sflash.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/spi/tegra20_sflash.c b/drivers/spi/tegra20_sflash.c
>> index 9322ce7..7c3a3fc 100644
>> --- a/drivers/spi/tegra20_sflash.c
>> +++ b/drivers/spi/tegra20_sflash.c
>> @@ -132,8 +132,6 @@ struct spi_slave *tegra20_spi_setup_slave(unsigned int
>> bus, unsigned int cs, printf("SPI error: malloc of SPI structure
>> failed\n");
>>   		return NULL;
>>   	}
>> -	spi->slave.bus = bus;
>> -	spi->slave.cs = cs;
>>   	spi->ctrl = &spi_ctrls[bus];
>>   	if (!spi->ctrl) {
>>   		printf("SPI error: could not find controller for bus %d\n",
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
>
Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>

--
Thanks,
Jagan.

  reply	other threads:[~2013-06-13 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  8:17 [U-Boot] [PATCH 1/2] spi: tegra114_spi: Convert to use spi_alloc_slave() Axel Lin
2013-06-13  8:21 ` [U-Boot] [PATCH 2/2] spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave Axel Lin
2013-06-13 10:48   ` Marek Vasut
2013-06-13 14:08     ` Jagan Teki [this message]
2013-06-13 17:33   ` [U-Boot] [U-Boot, " Jagan Teki
2013-06-13 10:48 ` [U-Boot] [PATCH 1/2] spi: tegra114_spi: Convert to use spi_alloc_slave() Marek Vasut
2013-06-13 14:08   ` Jagan Teki
2013-06-13 17:33 ` [U-Boot] [U-Boot, " Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B9D26A.9090109@gmail.com \
    --to=jagannadh.teki@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.