From: Jagan Teki <jagannadh.teki@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] spi: armada100_spi: Remove unnecessary NULL test for dout and din
Date: Thu, 13 Jun 2013 23:02:50 +0530 [thread overview]
Message-ID: <51BA0242.50800@gmail.com> (raw)
In-Reply-To: <1370959051.3720.1.camel@phoenix>
On 11-06-2013 19:27, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Acked-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>
> ---
> drivers/spi/armada100_spi.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c
> index afdbe05..b237c7c 100644
> --- a/drivers/spi/armada100_spi.c
> +++ b/drivers/spi/armada100_spi.c
> @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
> goto done;
> }
>
> - if (dout)
> - pss->tx = dout;
> - else
> - pss->tx = NULL;
> -
> - if (din)
> - pss->rx = din;
> - else
> - pss->rx = NULL;
> + pss->tx = dout;
> + pss->rx = din;
>
> if (flags & SPI_XFER_BEGIN) {
> spi_cs_activate(slave);
>
Applied to u-boot-spi/master
--
Thanks,
Jagan.
prev parent reply other threads:[~2013-06-13 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 13:57 [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din Axel Lin
2013-06-11 14:49 ` Simon Glass
2013-06-12 8:38 ` Marek Vasut
2013-06-12 10:19 ` Ajay Bhargav
2013-06-12 19:04 ` Jagan Teki
2013-06-13 17:32 ` Jagan Teki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA0242.50800@gmail.com \
--to=jagannadh.teki@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.