From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [RFC: PATCH] err.h: silence warning when using IS_ERR on void __iomem *
Date: Thu, 13 Jun 2013 21:19:30 +0200 [thread overview]
Message-ID: <51BA1B42.5090400@pengutronix.de> (raw)
In-Reply-To: <20130613182447.GB32574@mithrandir>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
On 06/13/2013 08:24 PM, Thierry Reding wrote:
> On Thu, Jun 13, 2013 at 10:55:17AM +0530, Sachin Kamat wrote:
>> On 13 June 2013 03:01, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>>> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
>>> introduced devm_ioremap_resource() and encourage to check its return value with
>>> IS_ERR(). This however leads to the following sparse warnings, as
>>> devm_ioremap_resource() returns a void __iomem pointer:
>>>
>>> drivers/net/can/c_can/c_can_platform.c:205:32: warning: incorrect type in argument 1 (different address spaces)
>>> drivers/net/can/c_can/c_can_platform.c:205:32: expected void const *ptr
>>> drivers/net/can/c_can/c_can_platform.c:205:32: got unsigned int [noderef] [usertype] <asn:2>*raminit_ctrlreg
>>
>> CC ing Thierry who has solved this issue some time back.
>
> I had sent two patches, one against sparse, the other against the
> kernel, but none were picked up yet.
Can you repost them? Hope someone will pick them up.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-06-13 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 21:31 [RFC: PATCH] err.h: silence warning when using IS_ERR on void __iomem * Marc Kleine-Budde
2013-06-13 5:25 ` Sachin Kamat
2013-06-13 18:24 ` Thierry Reding
2013-06-13 19:19 ` Marc Kleine-Budde [this message]
2013-06-13 20:14 ` Andrew Morton
2013-06-13 21:39 ` Thierry Reding
2013-06-17 7:59 ` Dan Carpenter
2013-06-17 10:11 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA1B42.5090400@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.