From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 13 Jun 2013 23:00:31 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:60254 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6835275Ab3FMVA3kYc0S (ORCPT ); Thu, 13 Jun 2013 23:00:29 +0200 Message-ID: <51BA32E3.7090006@imgtec.com> Date: Thu, 13 Jun 2013 16:00:19 -0500 From: "Steven J. Hill" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ralf Baechle CC: Subject: Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset. References: <1371075656-21374-1-git-send-email-Steven.Hill@imgtec.com> <20130613141820.GB22906@linux-mips.org> In-Reply-To: <20130613141820.GB22906@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.150.87] X-SEF-Processed: 7_3_0_01192__2013_06_13_22_00_23 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 36863 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Steven.Hill@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/13/2013 09:18 AM, Ralf Baechle wrote: > On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote: > > I think this is going to break Malta. We used to have: > > #define SOFTRES_REG 0x1e800050 > #define GORESET 0x4d > > for SEAD > Yes, it does break Malta. The #define values are defined in two places and I missed one of them. I have submitted a patchset to these cleaned up. Both platforms can now perform soft resets. Also, the 0x1e800050 is not correct. I check all the way back in our 2.6.32.15 tree and that value does not show up anywhere. The value in the patchset for SEAD-3 is the correct one. -Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:60254 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6835275Ab3FMVA3kYc0S (ORCPT ); Thu, 13 Jun 2013 23:00:29 +0200 Message-ID: <51BA32E3.7090006@imgtec.com> Date: Thu, 13 Jun 2013 16:00:19 -0500 From: "Steven J. Hill" MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset. References: <1371075656-21374-1-git-send-email-Steven.Hill@imgtec.com> <20130613141820.GB22906@linux-mips.org> In-Reply-To: <20130613141820.GB22906@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ralf Baechle Cc: linux-mips@linux-mips.org Message-ID: <20130613210019.hSaVMQxWtFgdy6L3VFMM5G8R2b9NO-LnkA60Mt8IrT0@z> On 06/13/2013 09:18 AM, Ralf Baechle wrote: > On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote: > > I think this is going to break Malta. We used to have: > > #define SOFTRES_REG 0x1e800050 > #define GORESET 0x4d > > for SEAD > Yes, it does break Malta. The #define values are defined in two places and I missed one of them. I have submitted a patchset to these cleaned up. Both platforms can now perform soft resets. Also, the 0x1e800050 is not correct. I check all the way back in our 2.6.32.15 tree and that value does not show up anywhere. The value in the patchset for SEAD-3 is the correct one. -Steve