From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters
Date: Thu, 13 Jun 2013 18:10:12 -0400 [thread overview]
Message-ID: <51BA4344.7070608@redhat.com> (raw)
In-Reply-To: <1371124063-12971-4-git-send-email-kwolf@redhat.com>
Il 13/06/2013 07:47, Kevin Wolf ha scritto:
> + s->discard_passthrough[QCOW2_DISCARD_NEVER] = false,
> + s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true,
> + s->discard_passthrough[QCOW2_DISCARD_REQUEST] =
> + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_REQUEST,
> + flags & BDRV_O_UNMAP),
I think there should not be two ways to enable it, it is confusing.
> + s->discard_passthrough[QCOW2_DISCARD_SNAPSHOT] =
> + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_SNAPSHOT, true),
> + s->discard_passthrough[QCOW2_DISCARD_OTHER] =
> + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_OTHER, false),
Please document the defaults in qcow2_runtime_opts. (BTW, what is the
rationale?)
Paolo
next prev parent reply other threads:[~2013-06-13 22:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 11:47 [Qemu-devel] [PATCH 0/5] qcow2: Discard freed clusters Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 1/5] Revert "block: Disable driver-specific options for 1.5" Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 2/5] qcow2: Add refcount update reason to all callers Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters Kevin Wolf
2013-06-13 22:10 ` Paolo Bonzini [this message]
2013-06-14 8:31 ` Kevin Wolf
2013-06-14 14:16 ` Paolo Bonzini
2013-06-14 14:31 ` Kevin Wolf
2013-06-14 15:00 ` Paolo Bonzini
2013-06-17 15:41 ` Stefan Hajnoczi
2013-06-17 15:58 ` Kevin Wolf
2013-06-13 11:47 ` [Qemu-devel] [PATCH 4/5] qcow2: Batch discards Kevin Wolf
2013-06-17 15:45 ` Stefan Hajnoczi
2013-06-13 11:47 ` [Qemu-devel] [PATCH 5/5] block: Always enable discard on the protocol level Kevin Wolf
2013-06-13 22:06 ` Paolo Bonzini
2013-06-14 8:14 ` Kevin Wolf
2013-06-18 3:03 ` [Qemu-devel] [PATCH 0/5] qcow2: Discard freed clusters Wenchao Xia
2013-06-18 6:25 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA4344.7070608@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.