From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnNSE-0003PZ-DD for qemu-devel@nongnu.org; Fri, 14 Jun 2013 02:25:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnNSB-0001d2-L9 for qemu-devel@nongnu.org; Fri, 14 Jun 2013 02:25:46 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:39044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnNSA-0001cm-Sa for qemu-devel@nongnu.org; Fri, 14 Jun 2013 02:25:43 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Jun 2013 00:25:42 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id B53061FF003C for ; Fri, 14 Jun 2013 00:20:27 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5E6PetG136488 for ; Fri, 14 Jun 2013 00:25:40 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5E6PdPO027666 for ; Fri, 14 Jun 2013 00:25:40 -0600 Message-ID: <51BAB763.1040501@linux.vnet.ibm.com> Date: Fri, 14 Jun 2013 02:25:39 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1370880226-2208-1-git-send-email-mrhines@linux.vnet.ibm.com> <4168C988EBDF2141B4E0B6475B6A73D10CE2AAC1@G6W2488.americas.hpqcorp.net> <51B60ABA.2070401@linux.vnet.ibm.com> <4168C988EBDF2141B4E0B6475B6A73D10CE2BAE7@G6W2488.americas.hpqcorp.net> <51B7B652.3070905@linux.vnet.ibm.com> <51B85EE5.1050702@hp.com> <51B868B3.9090607@linux.vnet.ibm.com> <51B9A614.2050101@hp.com> <51B9C2D6.30000@linux.vnet.ibm.com> <51B9D6A8.9070007@hp.com> <51B9DD5C.1030409@linux.vnet.ibm.com> <51BA264E.4010701@redhat.com> <51BA36DD.8050703@linux.vnet.ibm.com> <51BA3C4F.9030701@redhat.com> In-Reply-To: <51BA3C4F.9030701@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Juan Jose Quintela Carreira , "qemu-devel@nongnu.org" , Bulent Abali , "mrhines@us.ibm.com" , Anthony Liguori , Chegu Vinod On 06/13/2013 05:40 PM, Paolo Bonzini wrote: > Il 13/06/2013 17:17, Michael R. Hines ha scritto: >> On 06/13/2013 04:06 PM, Paolo Bonzini wrote: >>> Regarding the timestamp problem, it should be fixed in the RDMA code. >>> You did find a bug, but xyz_start_outgoing_migration should be >>> asynchronous and the pinning should happen in the setup phase. This is >>> because the setup phase is already running outside the big QEMU lock and >>> the guest would not be frozen. >> I think you misunderstood the symptom. The pinning is *already* >> happening in the setup phase (xyz_start_outgoing_migration), not >> inside the the migration_thread(). > I was referring to ram_control_before_iterate(f, RAM_CONTROL_SETUP). > Even better, that would be a good reason to remove the > > + * Please leave in place. These calls generate reserved messages in > + * the RDMA protocol in order to pre-register RDMA memory in the > + * future before the bulk round begins. > > comment that I don't like. :) > > xyz_start_outgoing_migration is the connect phase if you want to give it > a name. > > The connect phase runs with the big QEMU lock taken, so any interrupt > will freeze VCPUs until the pinning ends. Excellent suggestions. I've re-submitted the patch already with these modifications as v8. Thanks, Paolo. > > Juan, are you going to pick this up, or should Anthony do it? (Michael: > in any case, do not send a pull request yourself). Understood =).