From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 14 Jun 2013 10:26:26 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:19078 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822998Ab3FNI0Ywnz7X (ORCPT ); Fri, 14 Jun 2013 10:26:24 +0200 Message-ID: <51BAD3B0.9060605@imgtec.com> Date: Fri, 14 Jun 2013 09:26:24 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: David Daney CC: USB list , Ralf Baechle , Subject: Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled References: <1371138134-21216-1-git-send-email-markos.chandras@imgtec.com> <51B9F634.30506@gmail.com> In-Reply-To: <51B9F634.30506@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.58] X-SEF-Processed: 7_3_0_01192__2013_06_14_09_26_19 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 36873 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/13/13 17:41, David Daney wrote: > On 06/13/2013 08:42 AM, Markos Chandras wrote: >> Commit 94d83649e1c2f25c87dc4ead9c2ab073305 >> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture >> symbol" >> >> caused the following regression in cavium_octeon_defconfig: >> >> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects >> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies >> (USB_SUPPORT && USB && USB_EHCI_HCD) >> >> We fix this problem by selecting the USB_EHCI_HCD missing dependency >> if USB_SUPPORT is enabled. >> >> Signed-off-by: Markos Chandras >> Acked-by: Steven J. Hill > > NAK. This is incorrect. > > It is completely backwards and forces us to have EHCI unconditionally. > > The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other > Kconifg variables) out of the conditional section and make them > universally visible/usable. > > David Daney > > Hi David, Thanks. I will prepare a new patch. -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:19078 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822998Ab3FNI0Ywnz7X (ORCPT ); Fri, 14 Jun 2013 10:26:24 +0200 Message-ID: <51BAD3B0.9060605@imgtec.com> Date: Fri, 14 Jun 2013 09:26:24 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled References: <1371138134-21216-1-git-send-email-markos.chandras@imgtec.com> <51B9F634.30506@gmail.com> In-Reply-To: <51B9F634.30506@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney Cc: USB list , Ralf Baechle , linux-mips@linux-mips.org Message-ID: <20130614082624.nGElQxuV62lNFsqbY5uQIREtOJ_kXTXqI2BI_eBZuw4@z> On 06/13/13 17:41, David Daney wrote: > On 06/13/2013 08:42 AM, Markos Chandras wrote: >> Commit 94d83649e1c2f25c87dc4ead9c2ab073305 >> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture >> symbol" >> >> caused the following regression in cavium_octeon_defconfig: >> >> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects >> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies >> (USB_SUPPORT && USB && USB_EHCI_HCD) >> >> We fix this problem by selecting the USB_EHCI_HCD missing dependency >> if USB_SUPPORT is enabled. >> >> Signed-off-by: Markos Chandras >> Acked-by: Steven J. Hill > > NAK. This is incorrect. > > It is completely backwards and forces us to have EHCI unconditionally. > > The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other > Kconifg variables) out of the conditional section and make them > universally visible/usable. > > David Daney > > Hi David, Thanks. I will prepare a new patch. -- markos