diff for duplicates of <51BAD77D.5030007@huawei.com> diff --git a/a/1.txt b/N1/1.txt index 387df50..faa8079 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -59,12 +59,12 @@ On 2013/6/6 15:34, Yijing Wang wrote: > - unsigned int new_count; > - struct pci_window *new_window; > - -> - if (count = 0) +> - if (count == 0) > - return; > - idx = controller->windows; > - new_count = controller->windows + count; > - new_window = kcalloc(new_count, sizeof(struct pci_window), GFP_KERNEL); -> - BUG_ON(new_window = NULL); +> - BUG_ON(new_window == NULL); > - if (controller->window) { > - memcpy(new_window, controller->window, > - sizeof(struct pci_window) * controller->windows); @@ -73,7 +73,7 @@ On 2013/6/6 15:34, Yijing Wang wrote: > - > - /* Setup a pci_window for each device resource. */ > - for (i = 0; i <= PCI_ROM_RESOURCE; i++) { -> - if (pci_addrs[i] = -1) +> - if (pci_addrs[i] == -1) > - continue; > - > - new_window[idx].offset = dev->resource[i].start - pci_addrs[i]; @@ -110,7 +110,7 @@ On 2013/6/6 15:34, Yijing Wang wrote: > @@ -237,11 +192,8 @@ sn_io_slot_fixup(struct pci_dev *dev) > end = dev->resource[idx].end; > size = end - start; -> if (size = 0) { +> if (size == 0) { > - pci_addrs[idx] = -1; > continue; > } diff --git a/a/content_digest b/N1/content_digest index bd07285..d58eb7b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,16 +2,16 @@ "ref\01370504093-14908-2-git-send-email-wangyijing@huawei.com\0" "From\0Yijing Wang <wangyijing@huawei.com>\0" "Subject\0Re: [PATCH -v5 1/8] PCI/IA64: SN: remove sn_pci_window_fixup()\0" - "Date\0Fri, 14 Jun 2013 08:42:37 +0000\0" + "Date\0Fri, 14 Jun 2013 16:42:37 +0800\0" "To\0Bjorn Helgaas <bhelgaas@google.com>\0" "Cc\0Yijing Wang <wangyijing@huawei.com>" Yinghai Lu <yinghai@kernel.org> - linux-pci@vger.kernel.org + <linux-pci@vger.kernel.org> Tony Luck <tony.luck@intel.com> - linux-ia64@vger.kernel.org + <linux-ia64@vger.kernel.org> Fenghua Yu <fenghua.yu@intel.com> Hanjun Guo <guohanjun@huawei.com> - jiang.liu@huawei.com + <jiang.liu@huawei.com> John Keller <jpk@sgi.com> Jay Lan <jlan@engr.sgi.com> Jack Steiner <steiner@sgi.com> @@ -79,12 +79,12 @@ "> -\tunsigned int new_count;\n" "> -\tstruct pci_window *new_window;\n" "> -\n" - "> -\tif (count = 0)\n" + "> -\tif (count == 0)\n" "> -\t\treturn;\n" "> -\tidx = controller->windows;\n" "> -\tnew_count = controller->windows + count;\n" "> -\tnew_window = kcalloc(new_count, sizeof(struct pci_window), GFP_KERNEL);\n" - "> -\tBUG_ON(new_window = NULL);\n" + "> -\tBUG_ON(new_window == NULL);\n" "> -\tif (controller->window) {\n" "> -\t\tmemcpy(new_window, controller->window,\n" "> -\t\t sizeof(struct pci_window) * controller->windows);\n" @@ -93,7 +93,7 @@ "> -\n" "> -\t/* Setup a pci_window for each device resource. */\n" "> -\tfor (i = 0; i <= PCI_ROM_RESOURCE; i++) {\n" - "> -\t\tif (pci_addrs[i] = -1)\n" + "> -\t\tif (pci_addrs[i] == -1)\n" "> -\t\t\tcontinue;\n" "> -\n" "> -\t\tnew_window[idx].offset = dev->resource[i].start - pci_addrs[i];\n" @@ -130,7 +130,7 @@ "> @@ -237,11 +192,8 @@ sn_io_slot_fixup(struct pci_dev *dev)\n" "> \t\tend = dev->resource[idx].end;\n" "> \t\tsize = end - start;\n" - "> \t\tif (size = 0) {\n" + "> \t\tif (size == 0) {\n" "> -\t\t\tpci_addrs[idx] = -1;\n" "> \t\t\tcontinue;\n" "> \t\t}\n" @@ -158,4 +158,4 @@ "Thanks!\n" Yijing -9c09c30c47ef33f6f84d98b1c3cc21b8538247d9dd399623fa91ddfcf4df364c +5bd5cba3aeffbb73a669692af6988469f58770046bafa53130a2e7dcffd5bd8e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.