From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnUcO-0003uQ-Ia for qemu-devel@nongnu.org; Fri, 14 Jun 2013 10:04:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnUcK-0006QN-0P for qemu-devel@nongnu.org; Fri, 14 Jun 2013 10:04:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47951 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnUcJ-0006Q3-QW for qemu-devel@nongnu.org; Fri, 14 Jun 2013 10:04:39 -0400 Message-ID: <51BB22F4.2060504@suse.de> Date: Fri, 14 Jun 2013 16:04:36 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1371208516-7857-1-git-send-email-armbru@redhat.com> <1371208516-7857-16-git-send-email-armbru@redhat.com> <8761xgg5n5.fsf@codemonkey.ws> In-Reply-To: <8761xgg5n5.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: jan.kiszka@siemens.com, Markus Armbruster , qemu-devel@nongnu.org, Blue Swirl , alex.williamson@redhat.com, aviksil@linux.vnet.ibm.com Am 14.06.2013 15:53, schrieb Anthony Liguori: > Markus Armbruster writes: >=20 >> Next commit needs it. >> >> Cc: Blue Swirl >> Signed-off-by: Markus Armbruster >> --- >> tests/boot-order-test.c | 24 ++++++++++++++++-------- >> 1 file changed, 16 insertions(+), 8 deletions(-) >> >> diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c >> index 7b1edc1..d1d99f8 100644 >> --- a/tests/boot-order-test.c >> +++ b/tests/boot-order-test.c >> @@ -133,23 +133,31 @@ static void test_prep_boot_order(void) >> test_boot_orders("prep", read_boot_order_prep, test_cases_prep); >> } >> =20 >> -static void read_fw_cfg(uint64_t cfg_addr, uint16_t cmd, >> +static void read_fw_cfg(uint64_t cfg_addr, bool addr_is_io, uint16_t = cmd, >> void *buf, size_t len) >=20 > I missed it earlier, but you can use libqos/fw_cfg.h for this. Agree, but that didn't exist at the time. :-) Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg