diff for duplicates of <51BB29A4.7090106@gmail.com> diff --git a/a/1.txt b/N1/1.txt index d33933e..d1573bf 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ On 06/13/2013 12:04 PM, Daniel Borkmann wrote: > @@ -134,9 +134,18 @@ static void sctp_seq_dump_local_addrs(struct seq_file *seq, struct sctp_ep_commo > struct sctp_af *af; > -> if (epb->type = SCTP_EP_TYPE_ASSOCIATION) { +> if (epb->type == SCTP_EP_TYPE_ASSOCIATION) { > - asoc = sctp_assoc(epb); > - peer = asoc->peer.primary_path; > - primary = &peer->saddr; @@ -32,7 +32,7 @@ On 06/13/2013 12:04 PM, Daniel Borkmann wrote: > + * interpreter SCTP_CMD_ASOC_NEW was called on a non-fully > + * set up association. So do hara-kiri until this is fixed. > + */ -> + BUG_ON(peer = NULL); +> + BUG_ON(peer == NULL); > + primary = &peer->saddr; I am still trying to convince myself whether this BUG_ON() is the right @@ -45,7 +45,7 @@ overkill, especially considering that the system might have stayed up if the user did not read /proc. One thought I had was to change the above into something like this: - if (peer = NULL) { + if (peer == NULL) { WARN(1, "Association %p with NULL primary path", asoc); return; } @@ -53,7 +53,7 @@ One thought I had was to change the above into something like this: And add the following to handler for SCTP_CMD_NEW_ASOC and may be also to sctp_cmd_delete_tcb() - BUG_ON(asoc->peer.primary_path = NULL); + BUG_ON(asoc->peer.primary_path == NULL); This way, we would bug on additional and removal paths which have the possibility of giving us a lot more information about why the condition diff --git a/a/content_digest b/N1/content_digest index 054991b..417e110 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01371139463-12512-2-git-send-email-dborkman@redhat.com\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" "Subject\0Re: [PATCH net-next 1/4] net: sctp: sctp_seq_dump_local_addrs: throw BUG if primary_path is NULL\0" - "Date\0Fri, 14 Jun 2013 14:33:08 +0000\0" + "Date\0Fri, 14 Jun 2013 10:33:08 -0400\0" "To\0Daniel Borkmann <dborkman@redhat.com>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -29,7 +29,7 @@ "> @@ -134,9 +134,18 @@ static void sctp_seq_dump_local_addrs(struct seq_file *seq, struct sctp_ep_commo\n" "> \tstruct sctp_af *af;\n" ">\n" - "> \tif (epb->type = SCTP_EP_TYPE_ASSOCIATION) {\n" + "> \tif (epb->type == SCTP_EP_TYPE_ASSOCIATION) {\n" "> -\t asoc = sctp_assoc(epb);\n" "> -\t peer = asoc->peer.primary_path;\n" "> -\t primary = &peer->saddr;\n" @@ -43,7 +43,7 @@ "> +\t\t * interpreter SCTP_CMD_ASOC_NEW was called on a non-fully\n" "> +\t\t * set up association. So do hara-kiri until this is fixed.\n" "> +\t\t */\n" - "> +\t\tBUG_ON(peer = NULL);\n" + "> +\t\tBUG_ON(peer == NULL);\n" "> +\t\tprimary = &peer->saddr;\n" "\n" "I am still trying to convince myself whether this BUG_ON() is the right \n" @@ -56,7 +56,7 @@ "if the user did not read /proc.\n" "\n" "One thought I had was to change the above into something like this:\n" - "\tif (peer = NULL) {\n" + "\tif (peer == NULL) {\n" "\t\tWARN(1, \"Association %p with NULL primary path\", asoc);\n" "\t\treturn;\n" "\t}\n" @@ -64,7 +64,7 @@ "And add the following to handler for SCTP_CMD_NEW_ASOC and may be also \n" "to sctp_cmd_delete_tcb()\n" "\n" - "\tBUG_ON(asoc->peer.primary_path = NULL);\n" + "\tBUG_ON(asoc->peer.primary_path == NULL);\n" "\n" "This way, we would bug on additional and removal paths which have the\n" "possibility of giving us a lot more information about why the condition\n" @@ -79,4 +79,4 @@ "> \trcu_read_lock();\n" > -9aa86c3748eb7a9afc8e2fa8ed81b97f33d31863220f455fd3523cc97cae12ec +3513af13023334a0f7a49bfddbb233836e5a6cc4002820aa7dba1fd4679a12b5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.