diff for duplicates of <51BB30F3.7080606@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 511d4e8..9a24d62 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -22,7 +22,7 @@ On 06/14/2013 10:51 AM, Daniel Borkmann wrote: >>> seq_file *seq, struct sctp_ep_commo >>> struct sctp_af *af; >>> ->>> if (epb->type = SCTP_EP_TYPE_ASSOCIATION) { +>>> if (epb->type == SCTP_EP_TYPE_ASSOCIATION) { >>> - asoc = sctp_assoc(epb); >>> - peer = asoc->peer.primary_path; >>> - primary = &peer->saddr; @@ -36,7 +36,7 @@ On 06/14/2013 10:51 AM, Daniel Borkmann wrote: >>> + * interpreter SCTP_CMD_ASOC_NEW was called on a non-fully >>> + * set up association. So do hara-kiri until this is fixed. >>> + */ ->>> + BUG_ON(peer = NULL); +>>> + BUG_ON(peer == NULL); >>> + primary = &peer->saddr; >> >> I am still trying to convince myself whether this BUG_ON() is the @@ -60,7 +60,7 @@ On 06/14/2013 10:51 AM, Daniel Borkmann wrote: > for quite a while. > >> One thought I had was to change the above into something like this: ->> if (peer = NULL) { +>> if (peer == NULL) { >> WARN(1, "Association %p with NULL primary path", asoc); >> return; >> } @@ -88,7 +88,7 @@ changes we would at least have a bit more information to go on. >> And add the following to handler for SCTP_CMD_NEW_ASOC and may be also >> to sctp_cmd_delete_tcb() >> ->> BUG_ON(asoc->peer.primary_path = NULL); +>> BUG_ON(asoc->peer.primary_path == NULL); >> >> This way, we would bug on additional and removal paths which have the >> possibility of giving us a lot more information about why the condition diff --git a/a/content_digest b/N1/content_digest index 113900a..ec51921 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\051BB2DE6.40703@redhat.com\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" "Subject\0Re: [PATCH net-next 1/4] net: sctp: sctp_seq_dump_local_addrs: throw BUG if primary_path is NULL\0" - "Date\0Fri, 14 Jun 2013 15:04:19 +0000\0" + "Date\0Fri, 14 Jun 2013 11:04:19 -0400\0" "To\0Daniel Borkmann <dborkman@redhat.com>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -35,7 +35,7 @@ ">>> seq_file *seq, struct sctp_ep_commo\n" ">>> struct sctp_af *af;\n" ">>>\n" - ">>> if (epb->type = SCTP_EP_TYPE_ASSOCIATION) {\n" + ">>> if (epb->type == SCTP_EP_TYPE_ASSOCIATION) {\n" ">>> - asoc = sctp_assoc(epb);\n" ">>> - peer = asoc->peer.primary_path;\n" ">>> - primary = &peer->saddr;\n" @@ -49,7 +49,7 @@ ">>> + * interpreter SCTP_CMD_ASOC_NEW was called on a non-fully\n" ">>> + * set up association. So do hara-kiri until this is fixed.\n" ">>> + */\n" - ">>> + BUG_ON(peer = NULL);\n" + ">>> + BUG_ON(peer == NULL);\n" ">>> + primary = &peer->saddr;\n" ">>\n" ">> I am still trying to convince myself whether this BUG_ON() is the\n" @@ -73,7 +73,7 @@ "> for quite a while.\n" ">\n" ">> One thought I had was to change the above into something like this:\n" - ">> if (peer = NULL) {\n" + ">> if (peer == NULL) {\n" ">> WARN(1, \"Association %p with NULL primary path\", asoc);\n" ">> return;\n" ">> }\n" @@ -101,7 +101,7 @@ ">> And add the following to handler for SCTP_CMD_NEW_ASOC and may be also\n" ">> to sctp_cmd_delete_tcb()\n" ">>\n" - ">> BUG_ON(asoc->peer.primary_path = NULL);\n" + ">> BUG_ON(asoc->peer.primary_path == NULL);\n" ">>\n" ">> This way, we would bug on additional and removal paths which have the\n" ">> possibility of giving us a lot more information about why the condition\n" @@ -118,4 +118,4 @@ ">\n" > Daniel -9c62181fda00b3d1cd72e68251ed76d934bd39f7e59b7101c957310b633cd31d +8fee533a15888082000b72240ab3243e8115a9e45259f02e2eee7c7db3e75070
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.