All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: jackie.huang@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] do not pass CFLAGS to gcc while building libcap
Date: Fri, 14 Jun 2013 08:11:02 -0700	[thread overview]
Message-ID: <51BB3286.8020902@linux.intel.com> (raw)
In-Reply-To: <1371197373-10741-1-git-send-email-jackie.huang@windriver.com>

On 06/14/2013 01:09 AM, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> During do_configure(), we modify the BUILD_CFLAGS used
> but do not remove the default inclusion of CFLAGS
> in BUILD_CFLAGS.  This fix removes CFLAGS inclusion
> by modifying do_configure().
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>   meta/recipes-support/libcap/libcap.inc |    6 ++++--
>   1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/libcap/libcap.inc b/meta/recipes-support/libcap/libcap.inc
> index 2fd5718..5ace7d7 100644
> --- a/meta/recipes-support/libcap/libcap.inc
> +++ b/meta/recipes-support/libcap/libcap.inc
> @@ -12,15 +12,17 @@ DEPENDS_class-native = "perl-native-runtime"
>
>   SRC_URI = "${DEBIAN_MIRROR}/main/libc/libcap2/${BPN}2_${PV}.orig.tar.gz"
>
> -PR = "r2"
> +PR = "r3"
>
No PR bumps needed here or in your other patch, in this case they cause 
trouble if the 2 patches are not applied in order!

Sau!


>   inherit lib_package
>
> +# do NOT pass target cflags to host compilations
> +#
>   do_configure() {
>   	# libcap uses := for compilers, fortunately, it gives us a hint
>   	# on what should be replaced with ?=
>   	sed -e 's,:=,?=,g' -i Make.Rules
> -	sed -e 's,BUILD_CFLAGS ?=,BUILD_CFLAGS := $(BUILD_CFLAGS),' -i Make.Rules
> +	sed -e 's,^BUILD_CFLAGS ?= $(CFLAGS),BUILD_CFLAGS := $(BUILD_CFLAGS),' -i Make.Rules
>   }
>
>   EXTRA_OEMAKE = " \
> --
> 1.7.4.1
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>


      reply	other threads:[~2013-06-14 15:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:09 [PATCH] do not pass CFLAGS to gcc while building libcap jackie.huang
2013-06-14 15:11 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BB3286.8020902@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=jackie.huang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.