All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagannadh.teki@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] spi: mxc_spi: Use DIV_ROUND_UP at appropriate places
Date: Fri, 14 Jun 2013 22:35:41 +0530	[thread overview]
Message-ID: <51BB4D65.2070206@gmail.com> (raw)
In-Reply-To: <51BB328A.5040501@gmail.com>

On 14-06-2013 20:41, Jagan Teki wrote:
> On 14-06-2013 18:43, Axel Lin wrote:
>> This change slightly improves readability.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>>   drivers/spi/mxc_spi.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
>> index 5bed858..2ea3228 100644
>> --- a/drivers/spi/mxc_spi.c
>> +++ b/drivers/spi/mxc_spi.c
>> @@ -224,7 +224,7 @@ int spi_xchg_single(struct spi_slave *slave,
>> unsigned int bitlen,
>>       const u8 *dout, u8 *din, unsigned long flags)
>>   {
>>       struct mxc_spi_slave *mxcs = to_mxc_spi_slave(slave);
>> -    int nbytes = (bitlen + 7) / 8;
>> +    int nbytes = DIV_ROUND_UP(bitlen, 8);
>>       u32 data, cnt, i;
>>       struct cspi_regs *regs = (struct cspi_regs *)mxcs->base;
>>
>> @@ -294,7 +294,7 @@ int spi_xchg_single(struct spi_slave *slave,
>> unsigned int bitlen,
>>       /* Transfer completed, clear any pending request */
>>       reg_write(&regs->stat, MXC_CSPICTRL_TC | MXC_CSPICTRL_RXOVF);
>>
>> -    nbytes = (bitlen + 7) / 8;
>> +    nbytes = DIV_ROUND_UP(bitlen, 8);
>>
>>       cnt = nbytes % 32;
>>
>> @@ -330,7 +330,7 @@ int spi_xchg_single(struct spi_slave *slave,
>> unsigned int bitlen,
>>   int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const
>> void *dout,
>>           void *din, unsigned long flags)
>>   {
>> -    int n_bytes = (bitlen + 7) / 8;
>> +    int n_bytes = DIV_ROUND_UP(bitlen, 8);
>>       int n_bits;
>>       int ret;
>>       u32 blk_size;
>>
>
> Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>

Applied to u-boot-spi/master

--
Thanks,
Jagan.

  reply	other threads:[~2013-06-14 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 13:12 [U-Boot] [PATCH 1/2] spi: cf_qspi: Use DIV_ROUND_UP at appropriate place Axel Lin
2013-06-14 13:13 ` [U-Boot] [PATCH 2/2] spi: mxc_spi: Use DIV_ROUND_UP at appropriate places Axel Lin
2013-06-14 15:11   ` Jagan Teki
2013-06-14 17:05     ` Jagan Teki [this message]
2013-06-14 13:15 ` [U-Boot] [PATCH 1/2] spi: cf_qspi: Use DIV_ROUND_UP at appropriate place Richard Retanubun
2013-06-14 15:10   ` Jagan Teki
2013-06-14 17:05     ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BB4D65.2070206@gmail.com \
    --to=jagannadh.teki@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.