All of lore.kernel.org
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: airlied@linux.ie
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/nouveau: fix a memory leak.
Date: Sat, 15 Jun 2013 16:53:14 +0800	[thread overview]
Message-ID: <51BC2B7A.5030009@gmail.com> (raw)

When cleanup extra stat if this object was a notifier,it should free the
notifier.

Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
  drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c 
b/drivers/gpu/drm/nouveau/nouveau_abi16.c
index 1c4c6c9..b5252ff 100644
--- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
+++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
@@ -483,8 +483,7 @@ nouveau_abi16_ioctl_gpuobj_free(ABI16_IOCTL_ARGS)
      /* cleanup extra state if this object was a notifier */
      list_for_each_entry(ntfy, &chan->notifiers, head) {
          if (ntfy->handle == fini->handle) {
-            nouveau_mm_free(&chan->heap, &ntfy->node);
-            list_del(&ntfy->head);
+            nouveau_abi16_ntfy_fini(chan, ntfy);
              break;
          }
      }
-- 
1.8.1.2

                 reply	other threads:[~2013-06-15  8:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BC2B7A.5030009@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.