From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UnoIb-00059o-8s for mharc-qemu-trivial@gnu.org; Sat, 15 Jun 2013 07:05:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnoIY-00056Y-Ax for qemu-trivial@nongnu.org; Sat, 15 Jun 2013 07:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnoIX-0002st-1Z for qemu-trivial@nongnu.org; Sat, 15 Jun 2013 07:05:34 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnoIV-0002sQ-28; Sat, 15 Jun 2013 07:05:31 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 78F2E41740; Sat, 15 Jun 2013 15:05:28 +0400 (MSK) Message-ID: <51BC4A77.7020308@msgid.tls.msk.ru> Date: Sat, 15 Jun 2013 15:05:27 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: Peter Wu References: <1371292923-28105-1-git-send-email-mjt@msgid.tls.msk.ru> <12048990.5frBUX2jFf@al> In-Reply-To: <12048990.5frBUX2jFf@al> X-Enigmail-Version: 1.5.1 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Anthony Liguori , qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [PATCH trivial] vl: always define no_frame X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2013 11:05:35 -0000 15.06.2013 14:51, Peter Wu wrote: > On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote: > >> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke >> build of qemu without sdl, by referencing `no_frame' variable which is >> defined inside #if SDL block. Fix that by defining that variable >> unconditionally. > > Reviewed-by: Peter Wu Thanks! > As for the discussion about legacy options[1], are there plans to remove `-sdl` (replaced by `-display sdl`) and move the `-*-grab` and `-no-frame` to `-display sdl` options? If that is the idea, what about printing a message that the mentioned options are deprecated and removed in a future version? This is already done for sdl, see select_display() function in vl.c -- it handles -display sdl,frame={on|off},... It is unlikely the old options will be removed any time soon, and these will not likely print any warnings either -- this hasn't done for lots of other old options (-stdvga for example). Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnoIW-00056S-4f for qemu-devel@nongnu.org; Sat, 15 Jun 2013 07:05:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnoIV-0002sa-A6 for qemu-devel@nongnu.org; Sat, 15 Jun 2013 07:05:32 -0400 Message-ID: <51BC4A77.7020308@msgid.tls.msk.ru> Date: Sat, 15 Jun 2013 15:05:27 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1371292923-28105-1-git-send-email-mjt@msgid.tls.msk.ru> <12048990.5frBUX2jFf@al> In-Reply-To: <12048990.5frBUX2jFf@al> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Wu Cc: qemu-trivial@nongnu.org, Anthony Liguori , qemu-devel@nongnu.org 15.06.2013 14:51, Peter Wu wrote: > On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote: > >> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke >> build of qemu without sdl, by referencing `no_frame' variable which is >> defined inside #if SDL block. Fix that by defining that variable >> unconditionally. > > Reviewed-by: Peter Wu Thanks! > As for the discussion about legacy options[1], are there plans to remove `-sdl` (replaced by `-display sdl`) and move the `-*-grab` and `-no-frame` to `-display sdl` options? If that is the idea, what about printing a message that the mentioned options are deprecated and removed in a future version? This is already done for sdl, see select_display() function in vl.c -- it handles -display sdl,frame={on|off},... It is unlikely the old options will be removed any time soon, and these will not likely print any warnings either -- this hasn't done for lots of other old options (-stdvga for example). Thanks, /mjt