From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1Uo9si-0000kf-7d
	for qemu-devel@nongnu.org; Sun, 16 Jun 2013 06:08:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1Uo9sf-0001zx-7q
	for qemu-devel@nongnu.org; Sun, 16 Jun 2013 06:08:20 -0400
Received: from katherinewilliamsonsoprano.co.uk ([82.165.34.74]:40043
	helo=p15195424.pureserver.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1Uo9sf-0001zr-12
	for qemu-devel@nongnu.org; Sun, 16 Jun 2013 06:08:17 -0400
Message-ID: <51BD8E83.2000208@ilande.co.uk>
Date: Sun, 16 Jun 2013 11:08:03 +0100
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <1371304531-4194-1-git-send-email-mark.cave-ayland@ilande.co.uk>
	<51BC8029.20201@suse.de>
In-Reply-To: <51BC8029.20201@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] sun4m: add display width and height to the
 firmware configuration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 15/06/13 15:54, Andreas Färber wrote:

> Looks fine,
>
> Reviewed-by: Andreas Färber<afaerber@suse.de>
>
> Does this require corresponding OpenBIOS patches or was that already
> prepared? (only see your cleanups and bug fixes there)

Yes, I rolled up some code for this in the corresponding OpenBIOS 
patchset but forgot to mention it in the commit message - see patch 11/20.

Incidentally I also forgot to mention in that same commit message that I 
had to tweak switch-arch to enable CONFIG_QEMU in the SPARC32 build too.

Given the size of the patchset, I'll see if any comments come in over 
the next few days and if nothing surfaces I'll simply tweak the message 
before commit.


ATB,

Mark.