From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UoG1C-0005Ui-DI
	for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:41:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UoG1B-0004kU-4P
	for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:41:30 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33174 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UoG1A-0004kM-Ur
	for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:41:29 -0400
Message-ID: <51BDEAB4.2020502@suse.de>
Date: Sun, 16 Jun 2013 18:41:24 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370805206-26574-1-git-send-email-afaerber@suse.de>
	<1370805206-26574-32-git-send-email-afaerber@suse.de>
	<87a9myzb25.fsf@blackfin.pond.sub.org> <51B643D8.9090909@suse.de>
	<87hah5xffi.fsf@blackfin.pond.sub.org>
In-Reply-To: <87hah5xffi.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify
	do_info_numa()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Am 11.06.2013 09:41, schrieb Markus Armbruster:
> Andreas F=C3=A4rber <afaerber@suse.de> writes:
>> If having patch 57/59 larger is not a concern (which getting rid of
>> open-coded CPU loops tried to address), then I can just convert the
>> loops in place alongside first_cpu / next_cpu.
>> Then still the question remains of whether you'd want to inline and dr=
op
>> qemu_for_each_cpu() afterwards, or whether we can establish some rules
>> of thumb when to use which?
>=20
> To be honest, I see no value in qemu_for_each_cpu().
>=20
> At a glance, PATCH 57 looks fairly mechanical to me.  Is it?  Would it
> remain so if refrains from converting simple loops to
> qemu_for_each_cpu()?

v2 does that now.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg