Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

["Andreas Färber" <afaerber@suse.de>]

Subject is misleading: it's intc/openpic_kvm, not kvm/openpic. Alex,
please fix when squashing.

Am 12.06.2013 22:32, schrieb Scott Wood:
> Enables support for the in-kernel MPIC that thas been merged into the
> KVM next branch.  This includes irqfd/KVM_IRQ_LINE support from Alex
> Graf (along with some other improvements).
> 
> Note from Alex regarding kvm_irqchip_create():
> 
>   On x86, one would call kvm_irqchip_create() to initialize an
>   in-kernel interrupt controller.  That function then goes ahead and
>   initializes global capability variables as well as the default irq
>   routing table.
> 
>   On ppc, we can't call kvm_irqchip_create() because we can have
>   different types of interrupt controllers.  So we want to do all the
>   things that function would do for us in the in-kernel device init
>   handler.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> v2: fix "llx" -> PRI_x64, and remove some broken leftover code
> involving reg_base.
> ---
>  default-configs/ppc-softmmu.mak   |    1 +
>  default-configs/ppc64-softmmu.mak |    1 +

This breaks KVM-enabled ppcemb-softmmu build with unresolved symbol
kvm_openpic_connect_vcpu() in e500.o. Fix in my patch:

http://patchwork.ozlabs.org/patch/251731/

Because intc/openpic.c gets rebuilt for each of the three ppc*-softmmu,
I added a patch to my qom-cpu-10 series to stop that for openpic. For
openpic_kvm I believe that won't be possible due to sysemu/kvm.h's
inline stubs.

Andreas

>  hw/intc/Makefile.objs             |    1 +
>  hw/intc/openpic_kvm.c             |  250 +++++++++++++++++++++++++++++++++++++
>  hw/ppc/e500.c                     |   79 +++++++++++-
>  include/hw/ppc/openpic.h          |    2 +-
>  6 files changed, 328 insertions(+), 6 deletions(-)
>  create mode 100644 hw/intc/openpic_kvm.c

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg