From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UoNl4-0006l4-RI for mharc-qemu-trivial@gnu.org; Sun, 16 Jun 2013 20:57:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoNl1-0006fw-M9 for qemu-trivial@nongnu.org; Sun, 16 Jun 2013 20:57:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoNl0-0007Oa-Mq for qemu-trivial@nongnu.org; Sun, 16 Jun 2013 20:57:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47068 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoNkx-0007O0-GB; Sun, 16 Jun 2013 20:57:15 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C18F9A50E4; Mon, 17 Jun 2013 02:57:14 +0200 (CEST) Message-ID: <51BE5EE8.5070607@suse.de> Date: Mon, 17 Jun 2013 02:57:12 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Vladimir Senkov References: In-Reply-To: X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: qemu-trivial , Peter Crosthwaite , qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read) X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2013 00:57:20 -0000 Am 17.06.2013 02:43, schrieb Vladimir Senkov: > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 > From: Vladimir Senkov > > Date: Sun, 16 Jun 2013 20:30:52 -0400 > Subject: [PATCH] fixed a copy&paste error in serial.c >=20 > Signed-off-by: Vladimir Senkov > Patch is HTML-damaged unfortunately, we recommend git-send-email: http://wiki.qemu.org/Contribute/SubmitAPatch But since the patch is so trivial, maybe Peter or Michael can fix it up? Regards, Andreas > --- > hw/char/serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/char/serial.c b/hw/char/serial.c > index b537e42..6382f98 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -424,7 +424,7 @@ static uint64_t serial_ioport_read(void *opaque, > hwaddr addr, unsigned size) > ret =3D s->divider & 0xff; > } else { > if(s->fcr & UART_FCR_FE) { > - ret =3D fifo8_is_full(&s->recv_fifo) ? > + ret =3D fifo8_is_empty(&s->recv_fifo) ? > 0 : fifo8_pop(&s->recv_fifo); > if (s->recv_fifo.num =3D=3D 0) { > s->lsr &=3D ~(UART_LSR_DR | UART_LSR_BI); > -- > 1.8.1.2 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoNky-0006fp-Q1 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 20:57:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoNkx-0007O4-Mp for qemu-devel@nongnu.org; Sun, 16 Jun 2013 20:57:16 -0400 Message-ID: <51BE5EE8.5070607@suse.de> Date: Mon, 17 Jun 2013 02:57:12 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Senkov Cc: qemu-trivial , Peter Crosthwaite , qemu-devel@nongnu.org Am 17.06.2013 02:43, schrieb Vladimir Senkov: > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 > From: Vladimir Senkov > > Date: Sun, 16 Jun 2013 20:30:52 -0400 > Subject: [PATCH] fixed a copy&paste error in serial.c >=20 > Signed-off-by: Vladimir Senkov > Patch is HTML-damaged unfortunately, we recommend git-send-email: http://wiki.qemu.org/Contribute/SubmitAPatch But since the patch is so trivial, maybe Peter or Michael can fix it up? Regards, Andreas > --- > hw/char/serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/char/serial.c b/hw/char/serial.c > index b537e42..6382f98 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -424,7 +424,7 @@ static uint64_t serial_ioport_read(void *opaque, > hwaddr addr, unsigned size) > ret =3D s->divider & 0xff; > } else { > if(s->fcr & UART_FCR_FE) { > - ret =3D fifo8_is_full(&s->recv_fifo) ? > + ret =3D fifo8_is_empty(&s->recv_fifo) ? > 0 : fifo8_pop(&s->recv_fifo); > if (s->recv_fifo.num =3D=3D 0) { > s->lsr &=3D ~(UART_LSR_DR | UART_LSR_BI); > -- > 1.8.1.2 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg