From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH 1/3] drm: add mmap function to prime helpers
Date: Mon, 17 Jun 2013 11:02:32 +0900
Message-ID: <51BE6E38.70902@samsung.com>
References: <1371042979-14633-1-git-send-email-jy0922.shim@samsung.com>
	<51BB4FD5.7000401@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33])
	by gabe.freedesktop.org (Postfix) with ESMTP id 55B90E5D0B
	for <dri-devel@lists.freedesktop.org>;
	Sun, 16 Jun 2013 19:02:24 -0700 (PDT)
Received: from epcpsbgr2.samsung.com
	(u142.gpu120.samsung.co.kr [203.254.230.142])
	by mailout3.samsung.com (Oracle Communications Messaging Server
	7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011))
	with ESMTP id <0MOI007JELMTNVA0@mailout3.samsung.com> for
	dri-devel@lists.freedesktop.org; Mon, 17 Jun 2013 11:02:22 +0900 (KST)
In-reply-to: <51BB4FD5.7000401@nvidia.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Aaron Plattner <aplattner@nvidia.com>
Cc: "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On 06/15/2013 02:16 AM, Aaron Plattner wrote:
> On 06/12/2013 06:16 AM, Joonyoung Shim wrote:
>> This adds to call low-level mmap() from prime helpers.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>>   drivers/gpu/drm/drm_prime.c | 5 ++++-
>>   include/drm/drmP.h          | 2 ++
>>   2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index d92853e..3a008b2 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -165,7 +165,10 @@ static void drm_gem_dmabuf_kunmap(struct dma_buf 
>> *dma_buf,
>>   static int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf,
>>           struct vm_area_struct *vma)
>>   {
>> -    return -EINVAL;
>> +    struct drm_gem_object *obj = dma_buf->priv;
>> +    struct drm_device *dev = obj->dev;
>> +
>> +    return dev->driver->gem_prime_mmap(obj, vma);
>
> Won't this crash if the driver doesn't fill in the new field and 
> userspace tries to map it?
>

Right, if gem_prime_mmap field is NULL, should return error.

Thanks for comments.