All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
Date: Mon, 17 Jun 2013 08:38:26 +0200	[thread overview]
Message-ID: <51BEAEE2.8050700@googlemail.com> (raw)
In-Reply-To: <CAD=GYpbzYY9BsZ+iP9UkfL4f1A_Aj9gPfvWyD6bORfAkyb14WQ@mail.gmail.com>

Dear Joel A Fernandes,

On 16.06.13 17:44, Joel A Fernandes wrote:
> On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
> 
>> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>
>>
>> checkpatch.pl requires perl v5.10.0 to run but it
>> doesn't require to place in /usr/bin/perl
>> Use env to ensure that the interpreter used is the
>> first one on environment's $PATH on system with
>> several versions of perl installed.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>
>> ---
>>  tools/checkpatch.pl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
>> index 896e2bc..8dc5b9c 100755
>> --- a/tools/checkpatch.pl
>> +++ b/tools/checkpatch.pl
>> @@ -1,10 +1,11 @@
>> -#!/usr/bin/perl -w
>> +#!/usr/bin/env perl
> 
> 
> Would it not work to pass in the -w here?

this is not portable! BSD variants of env will only take a single parameter.

Best regards

Andreas Bie?mann

  parent reply	other threads:[~2013-06-17  6:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-16  7:16 [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path Jagannadha Sutradharudu Teki
2013-06-16  7:30 ` Sumit Gemini
2013-06-16 10:25   ` Michael Trimarchi
2013-06-16 13:42 ` Tom Rini
2013-06-16 15:44 ` Joel A Fernandes
2013-06-16 16:10   ` Jagannadha Sutradharudu Teki
2013-06-17  6:38   ` Andreas Bießmann [this message]
2013-06-17 14:47     ` Joel A Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BEAEE2.8050700@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.