Re: [PATCH 0/7][eclipse-poky] Add target profile quick switch

["Timo Müller" <mail@timomueller.eu>]

Hi Jessica,

Zhang, Jessica wrote, On 14.06.2013 21:42:
> Hi Timo,
>
> First thanks for continuous making improvement.  Most of the patches
> looked fine, but when I tested the functionality, I noticed that in
> either cases, your list contains: Project Specific and my customized
> profiles e.g. Standard Profile and profile_static.  I can toggle my
> customized profiles with no issue.  But if I click on the radio
> button for "project specific", I'm getting:
>
> The project specific target profile is not defined for the project
> "YHWC". You can define it in the projects property page
>
> Reason: Specified Toolchain Root Location is empty.
>
> So I'm a little lost here,do we really need this project specific
> option?

The "project specific" option correlates to the checkbox in the project
properties. The error you get is thrown if you haven't configured the
project specific profile in you project. I think in general this is
needed as otherwise the project specific would be kind of a
second-class profile

However, I think we can handle this error case more gracefully. I have
two possible ideas in mind, both with pros and cons:

1) disable/hide the project specific option, if it is not defined
in the project
* Pro: Only valid options are shown and accessible.
* Con: Might be confusing if the option is only available with some
projects. Especially if you haven't heard of the project specific
settings yet.

2) open the project properties to allow the user to do the configuration
* Pro: Forwards the user to the configuration page, allowing him to
quickly create the configuration.
* Con: Opens a new window. As there's no hint about the state of the
project specific configuration. The user might enter the configuration
page unintended.

I'm slightly in favour of option two. Maybe the cons can be worked
around by changing the label according to the state of the project
specific configuration. E.g. "Configure project specific" and "project
specific". I'll rework the patches to see how this feels like.

What do you think about this? Something I miss?

 > The other nit picking is, you have "projectSpeficic.label",
> is that a typo?

Yes, that's a typo. I will fix it along with the reworks mentioned
above.

>
> Thanks, Jessica
>
> -----Original Message----- From: yocto-bounces@yoctoproject.org
> [mailto:yocto-bounces@yoctoproject.org] On Behalf Of Timo Mueller
> Sent: Thursday, June 13, 2013 6:30 AM To: yocto@yoctoproject.org Cc:
> Timo Mueller Subject: [yocto] [PATCH 0/7][eclipse-poky] Add target
> profile quick switch
>
> From: Timo Mueller <timo.mueller@bmw-carit.de>
>
> Hi,
>
> if a user wants to change the used target profile of a project he
> currently has to open the project preferences. This can be tedious if
> he has to switch the profile often.
>
> This is a small addition which allows the user to quickly switch the
> used target profile of a project. Instead of having to open the
> project preferences the user can select the project in the navigator
> and then choose the desired target profile from a drop-down menu in
> the toolbar or from the project menu.
>
> 01: Small i18n fix 02..04: Refactoring the project specific utils
> 05..06: Introduce the target profile toolbar switch 07: Adds the
> target profile switch to the project menu
>
> Best regards, Timo
>
> Timo Mueller (7): plugins/sdk.ide: Use an internationalized dialog
> title plugins/sdk.ide: Extract project specific util methods
> plugins/sdk.ide: Move project specific util methods plugins/sdk.ide:
> Remove project context from method names plugins/sdk.ide: Add command
> to switch the target profile plugins/sdk.ide: Add profile switch menu
> to the toolbar plugins/sdk.ide: Add profile switch menu to the
> project menu
>
> .../OSGI-INF/l10n/bundle.properties                |   5 +
> plugins/org.yocto.sdk.ide/plugin.xml               | 105 +++++++++
> .../sdk/ide/TargetProfileContributionItem.java     | 121 +++++++++++
> .../org/yocto/sdk/ide/YoctoSDKMessages.properties  |   3 +
> .../src/org/yocto/sdk/ide/YoctoUISetting.java      |   3 +-
> .../sdk/ide/actions/ProfileSwitchHandler.java      | 154
> +++++++++++++ .../natures/YoctoSDKAutotoolsProjectNature.java    |
> 3 +- .../ide/preferences/YoctoSDKPreferencePage.java    |  11 +-
> .../preferences/YoctoSDKProjectPropertyPage.java   | 130 ++---------
> .../sdk/ide/utils/ProjectPreferenceUtils.java      | 240
> +++++++++++++++++++++
> .../src/org/yocto/sdk/ide/utils/YoctoSDKUtils.java | 118 ----------
> .../ide/wizard/NewYoctoProjectTemplateProcess.java |   3 +- 12 files
> changed, 651 insertions(+), 245 deletions(-)  create mode 100644
> plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/TargetProfileContributionItem.java
>
>
create mode 100644 
plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/actions/ProfileSwitchHandler.java
> create mode 100644
> plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/utils/ProjectPreferenceUtils.java
>
>  -- 1.8.1.4
>
> _______________________________________________ yocto mailing list
> yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
>

Best regards,
Timo