All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places
Date: Mon, 17 Jun 2013 12:40:32 +0200	[thread overview]
Message-ID: <51BEE7A0.5050602@denx.de> (raw)
In-Reply-To: <CAD6G_RSzXcDKoE-Cem1ac_8oKkpcTNu88SJrPXrkY=AObW69MQ@mail.gmail.com>

On 14/06/2013 15:18, Jagan Teki wrote:

>> This does not scale.
>> What if a (trivial) patch touches 10 drivers?
> Yes, you are correct if the changes is common to across the all drivers or
> If the changes which are more in 10 spi drivers out of 20 or > 10 for
> your example - use "spi: "
> and I think it's good to use above syntax as you changesd two drivers.
> 
> I am just showing the possibilities of using the coding guidelines,
> nothing more.

There is another issue: patman recognizes each <subpart>: and checks for
an alias to find the e-mail to send patches, and stops to go on if it is
not found. In this example, you can use patman if there is an entry for
spi: (and this is you as SPI custodian) and also for mxc_spi:, and
usually there is no maintainer for each driver. I agree that using a
long chain does not scale, and I think the hidden rule to use
<subsystem:> <subject> works well in most cases, Axel did in this patchset.

Regards,
Stefano



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-06-17 10:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  7:59 [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places Axel Lin
2013-06-14 12:20 ` Jagan Teki
2013-06-14 13:09   ` Axel Lin
2013-06-14 13:18     ` Jagan Teki
2013-06-17 10:40       ` Stefano Babic [this message]
2013-06-14 13:24     ` Richard Retanubun
2013-06-14 13:28       ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BEE7A0.5050602@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.