From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoZMN-00054G-BC for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoZME-0003KG-1q for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:20:39 -0400 Received: from ssl.dlhnet.de ([91.198.192.8]:53802 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoZMD-0003KC-SC for qemu-devel@nongnu.org; Mon, 17 Jun 2013 09:20:29 -0400 Message-ID: <51BF0D1C.7080601@dlhnet.de> Date: Mon, 17 Jun 2013 15:20:28 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1328704089-18691-1-git-send-email-kraxel@redhat.com> <77c7f18a4c427a64b1d16821b631e758.squirrel@ssl.dlhnet.de> <51BECD7E.4090305@redhat.com> <51BEED6D.7000008@dlhnet.de> <51BEFC62.6080109@redhat.com> In-Reply-To: <51BEFC62.6080109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Peter Lieven , qemu-devel@nongnu.org Am 17.06.2013 14:09, schrieb Gerd Hoffmann: > On 06/17/13 13:05, Peter Lieven wrote: >> Am 17.06.2013 10:49, schrieb Gerd Hoffmann: >>> On 06/17/13 10:10, Peter Lieven wrote: >>>> Hi Gerd, >>>> >>>> just looking at your patch. It works fine so far, but I am curious how >>>> to handle the lock keys? I have the problem that if I press caps lock >>>> and then create a new vnc session with exclusive access (from another >>>> terminal), the caps lock is still there. >>> >>> There is some logic for that in the vnc server, next time you press a >>> letter key it should get synced up. capslock+numlock can actually >>> easier go out of sync than the other modifiers, you don't need a >>> reconnect to trigger that: Activate some other window so the vnc client >>> window so it hasn't the keyboard focus, press capslock or numlock, move >>> focus back to the vnc window. >> >> It seems the sync logic fails iff. >> Caps Lock enabled -> VNC Disconnect -> Caps Lock disabled -> VNC Reconnect. >> In this case the guest OS is still typing uppercase letters. > > I guess reset_keys() should skip capslock+numlock to not disturb the > sync logic, can you try that? mhh, i might be wrong, but where could the vs->modifiers_state be not zero on a new connection. I only find a g_malloc0 initializing the VNCState. Peter