From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-test PATCH] kvmclock: serialize RDTSC Date: Mon, 17 Jun 2013 17:43:37 +0200 Message-ID: <51BF2EA9.3090903@redhat.com> References: <20130614213004.GA2250@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from mail-we0-f180.google.com ([74.125.82.180]:49114 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165Ab3FQPnm (ORCPT ); Mon, 17 Jun 2013 11:43:42 -0400 Received: by mail-we0-f180.google.com with SMTP id w56so2525921wes.11 for ; Mon, 17 Jun 2013 08:43:41 -0700 (PDT) In-Reply-To: <20130614213004.GA2250@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Il 14/06/2013 23:30, Marcelo Tosatti ha scritto: > > Serialize RDTSC so its executed inside kvmclock_read > section. > > Fixes https://bugzilla.redhat.com/show_bug.cgi?id=922285 > > Signed-off-by: Marcelo Tosatti > > diff --git a/x86/kvmclock.c b/x86/kvmclock.c > index 0624da3..5b831c5 100644 > --- a/x86/kvmclock.c > +++ b/x86/kvmclock.c > @@ -177,10 +177,10 @@ cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src) > > do { > version = pvclock_get_time_values(&shadow, src); > - barrier(); > + mb(); > offset = pvclock_get_nsec_offset(&shadow); > ret = shadow.system_timestamp + offset; > - barrier(); > + mb(); > } while (version != src->version); > > if ((valid_flags & PVCLOCK_RAW_CYCLE_BIT) || > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Applied, thanks. Paolo