From: Wolfgang Grandegger <wg@grandegger.com>
To: Mirza Krak <mirza.krak@hostmobility.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org,
Rickard Gustafsson <rickard.gustafsson@hostmobility.com>,
Tord Andersson <tord.andersson@endian.se>
Subject: Re: Dual SJA1000 can controllers on SMP system.
Date: Mon, 17 Jun 2013 21:34:42 +0200 [thread overview]
Message-ID: <51BF64D2.5000805@grandegger.com> (raw)
In-Reply-To: <51BF5A38.3080001@hostmobility.com>
On 06/17/2013 08:49 PM, Mirza Krak wrote:
> Thank you Marc for your patch. We applied it but it did not solve our
> problem.
>
> Wolfgang suggested defining a lock common for all devices:
>
> static DEFINE_SPINLOCK(snor_bus_lock);
>
> Which I applied and now it seems to work perfectly. Thank you for your
> help.
>
> Should I blame the hardware driver? :)
Even if there is a separate set of registers for each device, they can
obviously not be accessed concurrently. Well, you can say it's a
hardware feature, but a stupid and inefficient one.
Wolfgang.
next prev parent reply other threads:[~2013-06-17 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 11:20 Dual SJA1000 can controllers on SMP system mirza
2013-06-16 12:39 ` Wolfgang Grandegger
2013-06-17 6:10 ` Mirza Krak
2013-06-17 7:18 ` Marc Kleine-Budde
2013-06-17 13:46 ` Mirza Krak
2013-06-17 14:12 ` Marc Kleine-Budde
2013-06-17 18:49 ` Mirza Krak
2013-06-17 19:34 ` Wolfgang Grandegger [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-13 12:47 Mirza Krak
2013-06-16 9:20 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF64D2.5000805@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=mirza.krak@hostmobility.com \
--cc=mkl@pengutronix.de \
--cc=rickard.gustafsson@hostmobility.com \
--cc=tord.andersson@endian.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.