From: Andy Lutomirski <luto@amacapital.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/3] fbdev no more!
Date: Mon, 17 Jun 2013 13:47:23 -0700 [thread overview]
Message-ID: <51BF75DB.3090504@mit.edu> (raw)
In-Reply-To: <1371394640-1130-1-git-send-email-daniel.vetter@ffwll.ch>
On 06/16/2013 07:57 AM, Daniel Vetter wrote:
> Hi all,
>
> So I've taken a look again at the locking mess in our fbdev support and cried.
> Fixing up the console_lock mess around the fbdev notifier will be real work,
> semanatically the fbdev layer does lots of stupid things (like the radeon resume
> issue I've just debugged) and the panic notifier is pretty much a lost cause.
>
> So I've decided to instead rip it all out. It seems to work \o/
I wonder how badly this breaks on EFI systems. Currently, efifb is an
fbdev driver. When i915 calls register_framebuffer, the fbdev core
removes efifb's framebuffer. (This is scary already -- what if i915 has
reused that memory for something else beforehand?) But now, if i915
doesn't call register_framebuffer, the efifb "framebuffer" might stick
around forever.
Presumably, efifb ought to become a framebuffer-only drm driver and
there should be a saner way to hand control from efifb (or vesa?) to a
real driver.
--Andy
next prev parent reply other threads:[~2013-06-17 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 14:57 [PATCH 0/3] fbdev no more! Daniel Vetter
2013-06-16 14:57 ` [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers Daniel Vetter
2013-06-16 14:57 ` [PATCH 2/3] drm/i915: Kconfig option to disable the legacy fbdev support Daniel Vetter
2013-06-16 14:57 ` [PATCH 3/3] drm/i915: rename intel_fb.c to intel_fbdev.c Daniel Vetter
2013-06-16 22:07 ` [PATCH 0/3] fbdev no more! David Herrmann
2013-06-17 14:33 ` Konrad Rzeszutek Wilk
2013-06-18 6:37 ` Daniel Vetter
2013-06-18 7:21 ` [PATCH 0/8] Don't let the ghost eDP haunt us Zoltan Nyul
2013-06-17 20:47 ` Andy Lutomirski [this message]
2013-06-18 6:12 ` [PATCH 0/3] fbdev no more! David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF75DB.3090504@mit.edu \
--to=luto@amacapital.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.