All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect
Date: Tue, 18 Jun 2013 06:35:44 +0400	[thread overview]
Message-ID: <51BFC780.4090204@msgid.tls.msk.ru> (raw)
In-Reply-To: <51B70F11.7090101@msgid.tls.msk.ru>

11.06.2013 15:50, Michael Tokarev wrote:
> 11.06.2013 09:15, liguang wrote:
>> type last parameter of vnc_connect if bool,
>> so pass 'false' instead of '0' for it.
> 
> There's another parameter in here, `skipauth', which should be
> bool in vnc_connect(), and should be bool in vnc_display_add_client()
> too.
> 
> Also, there's no big point in splitting 1/5 and 2/5 (vnc_listen_read),
> I think.
> 
> Does something like the below look ok? (not even compile-tested)
> (and I'd really rename `skipauth' to `doauth' everywhere, to mean
> exactly the opposite so that we don't have double negatives, but
> it is too late already)

Hello.

Do you want/plan to respin the series, addressing comments?
Are you okay with my version?

Thanks!

/mjt


  parent reply	other threads:[~2013-06-18  2:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11  5:15 [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect liguang
2013-06-11  5:15 ` [Qemu-trivial] [PATCH 2/5] vnc: pass bool parameter for vnc_listen_read liguang
2013-06-11 11:36   ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
2013-06-11  5:15 ` [Qemu-trivial] [PATCH 3/5] qemu-char: pass bool parameter for qemu_opt_get_bool liguang
2013-06-11 11:35   ` Michael Tokarev
2013-06-18  2:33     ` [Qemu-trivial] [Qemu-devel] " li guang
2013-06-11  5:15 ` [Qemu-trivial] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending liguang
2013-06-11 11:34   ` Michael Tokarev
2013-06-18  2:32     ` [Qemu-trivial] [Qemu-devel] " li guang
2013-06-18  3:50       ` Michael Tokarev
2013-06-18  4:08         ` li guang
2013-06-11  5:15 ` [Qemu-trivial] [PATCH 5/5] sd: pass bool parameter for sd_init liguang
2013-06-11 11:39 ` [Qemu-trivial] [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect Andreas Färber
2013-06-11 11:50 ` [Qemu-trivial] " Michael Tokarev
2013-06-18  2:34   ` [Qemu-trivial] [Qemu-devel] " li guang
2013-06-18  2:35   ` Michael Tokarev [this message]
2013-06-18  2:36     ` [Qemu-trivial] " li guang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BFC780.4090204@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.