All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tegrarcm: Add version command
Date: Mon, 17 Jun 2013 21:58:57 -0600	[thread overview]
Message-ID: <51BFDB01.6030606@wwwdotorg.org> (raw)
In-Reply-To: <1371525867-2551-1-git-send-email-amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 06/17/2013 09:24 PM, Allen Martin wrote:
> Add command line option "--version" that prints the version number and
> exits.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

I assume you'll apply all these.

Although...

> +static void print_version(char *progname)
> +{
> +	fprintf(stderr, "%s %s\n", PACKAGE_NAME, PACKAGE_VERSION);
> +}

I wonder if that shouldn't print to stdout; it's the requested output of
the command, not some error message.

  parent reply	other threads:[~2013-06-18  3:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  3:24 [PATCH] tegrarcm: Add version command Allen Martin
     [not found] ` <1371525867-2551-1-git-send-email-amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-18  3:58   ` Stephen Warren [this message]
     [not found]     ` <51BFDB01.6030606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-18  4:40       ` Allen Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BFDB01.6030606@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.