Re: [Qemu-devel] [PATCH 2/7] savevm: export qemu_save_device_state()

[Lei Li <lilei@linux.vnet.ibm.com>]

On 06/17/2013 12:02 AM, Anthony Liguori wrote:
> Lei Li <lilei@linux.vnet.ibm.com> writes:
>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>>   include/sysemu/sysemu.h |    1 +
>>   savevm.c                |    2 +-
>>   2 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
>> index 2fb71af..5b90027 100644
>> --- a/include/sysemu/sysemu.h
>> +++ b/include/sysemu/sysemu.h
>> @@ -80,6 +80,7 @@ int qemu_savevm_state_iterate(QEMUFile *f);
>>   void qemu_savevm_state_complete(QEMUFile *f);
>>   void qemu_savevm_state_cancel(void);
>>   uint64_t qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size);
>> +int qemu_save_device_state(QEMUFile *f);
>>   int qemu_loadvm_state(QEMUFile *f);
> Please add comments describing what this function does.  I know they're
> absent for the rest of the functions but we have to start somewhere.

OK, will do.

>
> Regards,
>
> Anthony Liguori
>
>>   
>>   /* SLIRP */
>> diff --git a/savevm.c b/savevm.c
>> index 2ce439f..e3ad5da 100644
>> --- a/savevm.c
>> +++ b/savevm.c
>> @@ -2006,7 +2006,7 @@ static int qemu_savevm_state(QEMUFile *f)
>>       return ret;
>>   }
>>   
>> -static int qemu_save_device_state(QEMUFile *f)
>> +int qemu_save_device_state(QEMUFile *f)
>>   {
>>       SaveStateEntry *se;
>>   
>> -- 
>> 1.7.7.6


-- 
Lei