From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UosgT-00010w-G9 for qemu-devel@nongnu.org; Tue, 18 Jun 2013 05:58:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UosgR-0002KC-SN for qemu-devel@nongnu.org; Tue, 18 Jun 2013 05:58:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57228 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UosgR-0002Jw-KS for qemu-devel@nongnu.org; Tue, 18 Jun 2013 05:58:39 -0400 Message-ID: <51C02F4C.4070003@suse.de> Date: Tue, 18 Jun 2013 11:58:36 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <6e991961b746baaf40685a25eee20165ca587170.1371548267.git.peter.crosthwaite@xilinx.com> In-Reply-To: <6e991961b746baaf40685a25eee20165ca587170.1371548267.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH v1 1/7] target-arm/cpu.c: delete un-needed instance/class sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, edgar.iglesias@gmail.com Am 18.06.2013 11:44, schrieb peter.crosthwaite@xilinx.com: > From: Peter Crosthwaite >=20 > QOM automatically inherits class and instance size from the parent > class. No need to redefine as the same value as the parent. It would be fair to mention since which commit because that was originally not the case. :) >=20 > CC: qemu-trivial@nongnu.org >=20 > Signed-off-by: Peter Crosthwaite Anyway, Reviewed-by: Andreas F=E4rber Andreas > --- >=20 > target-arm/cpu.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/target-arm/cpu.c b/target-arm/cpu.c > index 496a59f..47a21ec 100644 > --- a/target-arm/cpu.c > +++ b/target-arm/cpu.c > @@ -821,9 +821,7 @@ static void cpu_register(const ARMCPUInfo *info) > { > TypeInfo type_info =3D { > .parent =3D TYPE_ARM_CPU, > - .instance_size =3D sizeof(ARMCPU), > .instance_init =3D info->initfn, > - .class_size =3D sizeof(ARMCPUClass), > .class_init =3D info->class_init, > }; > =20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg