From: Jan Kiszka <jan.kiszka@siemens.com>
To: Bas van Sisseren <bas@quarantainenet.nl>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks
Date: Tue, 18 Jun 2013 15:31:21 +0200 [thread overview]
Message-ID: <51C06129.8060802@siemens.com> (raw)
In-Reply-To: <51BEF5F4.5090309@quarantainenet.nl>
On 2013-06-17 13:41, Bas van Sisseren wrote:
> On 04/06/13 14:26, Stefan Hajnoczi wrote:
>> On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote:
>>> reorder slirp config options. first check the dns-server-address,
>>> then check the first-dhcp-address. the original code was comparing
>>> the first-dhcp-address with the default dns-server-address, not
>>> the configured dns-server-address.
>>>
>>> Signed-off-by: Bas van Sisseren <bas@quarantainenet.nl>
>>> ---
>>> net/slirp.c | 12 ++++++------
>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Hello qemu-devel list,
>
> The last reaction was 2 weeks ago. Do I need more reviews for inclusion of
> the patch?
>
Nope, thanks, just applied to my slirp queue.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2013-06-18 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:11 [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks Bas van Sisseren
2013-06-04 12:26 ` Stefan Hajnoczi
2013-06-17 11:41 ` Bas van Sisseren
2013-06-17 12:39 ` Stefan Hajnoczi
2013-06-18 13:31 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C06129.8060802@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=bas@quarantainenet.nl \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.