From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uox5f-0000ic-7x for qemu-devel@nongnu.org; Tue, 18 Jun 2013 10:41:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uox5b-0002cw-OV for qemu-devel@nongnu.org; Tue, 18 Jun 2013 10:40:58 -0400 Received: from mail-ye0-f181.google.com ([209.85.213.181]:64960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uox5b-0002cj-8A for qemu-devel@nongnu.org; Tue, 18 Jun 2013 10:40:55 -0400 Received: by mail-ye0-f181.google.com with SMTP id g12so1372098yee.12 for ; Tue, 18 Jun 2013 07:40:54 -0700 (PDT) Sender: Richard Henderson Message-ID: <51C07173.4000400@twiddle.net> Date: Tue, 18 Jun 2013 07:40:51 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1371515385-32203-1-git-send-email-afaerber@suse.de> <1371515385-32203-5-git-send-email-afaerber@suse.de> In-Reply-To: <1371515385-32203-5-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 4/6] target-alpha: Register VMStateDescription for AlphaCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org, quintela@redhat.com On 06/17/2013 05:29 PM, Andreas Färber wrote: > Commit b758aca1f6cdb175634812b79f5560c36c902d00 (target-alpha: Enable > the alpha-softmmu target.) introduced cpu_{save,load}() functions but > didn't define CPU_SAVE_VERSION, so they were never registered. > > Drop cpu_{save,load}() and register the VMStateDescription via DeviceClass. > This operates on the AlphaCPU object instead of CPUAlphaState. > > Signed-off-by: Andreas Färber > --- > target-alpha/cpu-qom.h | 4 ++++ > target-alpha/cpu.c | 2 ++ > target-alpha/machine.c | 28 ++++++++++++++++------------ > 3 files changed, 22 insertions(+), 12 deletions(-) Acked-by: Richard Henderson r~